Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional keys to groupedOutputs.data.*.stats.* to allow for better filtering support. #438

Open
connor-makowski opened this issue Jan 19, 2024 · 3 comments
Assignees

Comments

@connor-makowski
Copy link
Contributor

These should include:

allowFiltering: To allow a filter to be applied to this state
allowCharting: To allow a stat to be selected in the chart dropdown
help: To have a little help button next to this stat for user reference

The idea is that some stats might be used for filtering, but not charting and vice versa. In general, both allow values should default to true and the help should not show if it is null or blank.

@connor-makowski connor-makowski added the enhancement New feature or request label Jan 19, 2024
@connor-makowski connor-makowski moved this to Backlog in CAVE App Jan 19, 2024
@connor-makowski connor-makowski removed the enhancement New feature or request label Jan 19, 2024
@luisvasq
Copy link
Contributor

We have a filterable prop (added by Willem) for map filter items. Maybe we can rename allowCharting or simply stick with its name and rename filterable to allowFiltering.

@connor-makowski connor-makowski moved this from Backlog to Ready in CAVE App Feb 20, 2024
@connor-makowski
Copy link
Contributor Author

Are these in 2.1? If so we are stuck with them until 3.0

@luisvasq
Copy link
Contributor

luisvasq commented Mar 5, 2024

For now, it's only in cave_static because the default value of filterable is true, and it hasn't been added in any cave_app example yet. I think it's safe to rename it or change anything about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

4 participants