Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSRMRoadManager response (more data) and a small issue #435

Open
moiatto opened this issue Jun 9, 2023 · 2 comments
Open

OSRMRoadManager response (more data) and a small issue #435

moiatto opened this issue Jun 9, 2023 · 2 comments

Comments

@moiatto
Copy link

moiatto commented Jun 9, 2023

I'm working on converting the response of OSRMRoadManager(Road) to MapLibre(DirectionsRoute).
Everything works perfectly, but some data is missing.

Small mistake to correct
RoadLeg.mLength return the value in Meter while in the description of the item it is in Km.

Instead regarding the additional response data, the Road class is a bit limited.
It would be convenient and easy to make public the Json response.

@MKergall
Copy link
Owner

I didn't know the MapLibre initiative: sounds great! Bringing a free Android map lib supporting vector tiles is what I was dreaming for osmdroid for years.
You have been able to use MapLibre AND OSMBonusPack in the same project, "as is"?

Thanks for the feedback about RoadLeg.mLength, I will fix that.

About "It would be convenient and easy to make public the Json response": Not enthousiastic. For instance, the response is not necessarily a Json (could be an XML).

@moiatto
Copy link
Author

moiatto commented Jun 10, 2023

I didn't know the MapLibre initiative: sounds great! Bringing a free Android map lib supporting vector tiles is what I was dreaming for osmdroid for years. You have been able to use MapLibre AND OSMBonusPack in the same project, "as is"?

Let's say yes.
I use your library for geocoding and routing service, Mapsforge VTM (vector tiles) for maps and Maplibre for navigation management.

Thanks for the feedback about RoadLeg.mLength, I will fix that.

Perfect

About "It would be convenient and easy to make public the Json response": Not enthousiastic. For instance, the response is not necessarily a Json (could be an XML).

For me is the same. Let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants