Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Reawaken features don't work with PVP Style alternative playstyle #451

Open
luke0717 opened this issue Sep 21, 2024 · 4 comments
Assignees
Labels
bug Something isn't working dawntrail Dawntrail enhancement New feature or request planned

Comments

@luke0717
Copy link

Describe the bug
When using the PVP Style feature (for single target, aoe or for winder combo), the reawaken feature only displays the first generation/legacy combo, and gets stuck at that. It never goes over to 2nd, 3rd, etc.

To Reproduce
Please try to submit as much information as possible to reproduce the behavior:

  1. Version 2.0.0.12

  2. VPR

  3. I have the following features enabled:
    PVP Single, PVP AOE, PVP Winder, PVP Pit combo
    Generation Legacy feature
    All-in-one reawaken feature
    Merge twinfang/blood onto serpent tail (non relevant i imagine)

  4. Which skill is placed in your hotbar:
    Steel Fangs

  5. No other forks.

Expected behavior
I might be misunderstanding what's supposed to happen. But basically what I expected was for the skill to skill to go over every generation/legacy, to finish the combo. I only suspected it was a bug because it just gets stuck in the first generation. I have the reawaken skill in my hotbar and it works as intended with that skill. It's just with the pvp feature skill.

Screenshots or videos

image
Skill above is Reawaken skill, which progressed to Second Generation.. The one below is Steel Fangs (with pvp style feature enabled), stuck at First (doesn't switch back to main combo until Reawaken is spent).

@luke0717 luke0717 added bug Something isn't working dawntrail Dawntrail labels Sep 21, 2024
@IndigoAura
Copy link

As far as i know, this is normal behaviour. the all-in-one feature replaces the reawaken button with all parts of the combo, not steel fangs. steel fangs becoming first generation is vanilla/unmodded behaviour.

@kaedys
Copy link

kaedys commented Sep 24, 2024

I believe you're correct, @IndigoAura, but I believe @luke0717's ask probably makes sense. The basic concept of the PvP-Style main combo feature is that you don't need both Steel Fangs and Dread Fangs on your bar, it compresses all of it into Steel Fangs. That same logic would suggest that the Steel Fangs should act exactly like the Reawaken button does when it's feature is turned on, the entire Reawaken combo compressed on it. May be worth enabling that functionality via some subfeatures, but I think the ask makes sense.

@luke0717
Copy link
Author

Ah I see! I genuinely thought it was a bug, my bad. In this case, I think @kaedys said it all. We can treat this thread as a request then instead of a bug report, maybe? If that's okay.

@MKhayle
Copy link
Owner

MKhayle commented Sep 25, 2024

that's okay! I'm currently sick and not able to work much on this project lately, but I'll look into this

@MKhayle MKhayle changed the title [Bug] Reawaken features don't work with PVP Style alternative playstyle [Request] Reawaken features don't work with PVP Style alternative playstyle Sep 25, 2024
@MKhayle MKhayle added enhancement New feature or request planned labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dawntrail Dawntrail enhancement New feature or request planned
Projects
None yet
Development

No branches or pull requests

4 participants