Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax property association order on readers #113

Closed
y-guyon opened this issue Jan 20, 2025 · 2 comments
Closed

Relax property association order on readers #113

y-guyon opened this issue Jan 20, 2025 · 2 comments

Comments

@y-guyon
Copy link
Contributor

y-guyon commented Jan 20, 2025

Section 6.5.1 of HEIF says:

The semantics of the descriptive properties specified in 6.5 are specified for the image before the transformations, if any, are applied. Readers shall allow and ignore descriptive properties following the first transformative or unrecognized property, whichever is earlier, in the sequence associating properties with an item.

This leads to some issues:

Saying that descriptive properties describe items before any transformation should be enough in my opinion.

HEIF amendment suggestion

The semantics of the descriptive properties specified in 6.5 are specified for the image before the
transformations, if any, are applied.
- Readers shall
+ NOTE: In previous versions of this specification, readers had to 
allow and ignore descriptive properties following the first transformative or unrecognized property,
whichever is earlier, in the sequence associating properties with an item.

+ Writers should arrange the descriptive properties prior to any transformative property in the
+ sequence associating properties with an item.
Writers should arrange the descriptive properties specified in 6.5 prior to any other properties in the
sequence associating properties with an item.
@mhannuksela
Copy link
Collaborator

Hi @y-guyon,

I agree that the sentence in 6.5.1, which appeared already in HEIF v1, is problematic. I think it might have tried to say that even though descriptive properties are specified in 6.5 of HEIF v1 to appear before any transformative properties, future versions of HEIF or other specifications may specify a descriptive property propA that follows a transformative image property and describes the output of that transformation, in which case HEIF v1 readers shall not misinterpret the descriptive property propA to describe the reconstructed image (before transformations). The changes you are proposing are going to the right direction IMO. Additionally, I'd propose to add an explanation to the NOTE that you proposed:

NOTE: It is uncertain if readers would be able to correctly interpret descriptive properties that follow the first transformative property or the first unrecognized essential property, whichever is earlier, in the sequence associating properties with an item, because those descriptive properties possibly describe the output image after the transformation(s). In previous versions of this document, readers had to allow and ignore descriptive properties following the first transformative or unrecognized property, whichever is earlier, in the sequence associating properties with an item.

@cconcolato
Copy link
Contributor

We agree to include this text into the Amd2 of HEIF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants