-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BioSpheres by Kadax, TheCello, TheViola, and JackofLava #310
base: master
Are you sure you want to change the base?
Conversation
I think am not the person that should be saying it but:
|
The name is ok, I don't see any problem there, also what you said, you need to rename the screenshot screenshot.png, also I think that with one screenshot is enough |
Also would be much better if you put the map in singlenode, do /ctf_start and take a screenshot without barrier |
Then how do I change a file name that has been uploaded? Also I trying to delete the bottom screenshot |
You can or: 1. Open the .conf file in your computer and change it, or 2. Edit it from github, there's an option to do that when you go to the file |
|
I can't seem to edit or delete the existing screenshots that have been uploaded for some reason. Would someone, like HobbitPower, in the management/administration of the maps be able to delete or edit the existing screenshots on their end? |
How are you not able to do it? What hurdle is it that you aren't able to figure out? Anyone of us could potentially make a PR on your fork of the repo for the respective changes but it'd be better for you as well if we find what you're not able to figure out. And since you've made the PR, you'll have to manage it, and it would be quicker with you in control. You can put a screenshot of which step you aren't able to do so here or try to find solutions for it from the web, surely you can get a fix. Let us know the exact thing as well. |
Let me try again, I got a new laptop |
Try going to your fork of the repository and deleting the files from there. |
Yes this is what you need to do. Any changes you make to your master branch will appear in this PR. This is also why it's best to open a separate branch for each PR you make. Like for this one you could've created a new branch called 'biospheres', if you then decide to make another PR for another map you can create a new branch off of your master branch (which you cannot do now because it will add onto this PR). |
@JackofLava I can delete screenshots there so can you ;) I already deleted one of the screenshots, so you can try to delete the other one: Now you can add a new file. Take a new screenshot or take one (!) of the following screenshots for example. It must be named screenshot.png and should show no red barriers, no HUD, chat or coordinates. Also it must have a 3:2 ratio. Also I saw that the name of your folder is "BioSperes" instead of "bio_spheres". I don't know if that's a problem, usually the folder name of the maps is written in lower case. (@LoneWolfHT) |
|
@JackofLava when you are using the Website version of Github: go to your fork, press In the field you have to type a short message (Name change for example) and then you can click Commit & Push (the green field). In my test branch this worked at least. And again please change your screenshot. Delete the current one and upload a new one without the red barriers. I've also provided two for you to use if you'd like. |
This map indeed seems interesting :) |
@JackofLava I would just like to remind you that there are requests for changes. |
Ok, thank you for letting me know, I don't know when I will be able to get
to it though.
…On Tue, Jan 2, 2024 at 5:35 AM HobbitPower ***@***.***> wrote:
@JackofLava <https://github.com/JackofLava> I would just like to remind
you that there are requests for changes.
So if you are still interested in the map, please let us know.
There is also a new CTF Map Editor version, so the map should be updated
anyway. You will need the latest version of the CTF subgame, which can be
found in the Minetest Content Database.
—
Reply to this email directly, view it on GitHub
<#310 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BB55VWMOXMAJBB6KNTO6P7TYMPWIVAVCNFSM6AAAAAA3RK36I6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTHEYTMOJZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@JackofLava when the requested changes are applied, request for review |
No description provided.