Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove address_dao_transactions, use dao_events instead #297

Closed
ShiningRay opened this issue Apr 18, 2023 · 3 comments
Closed

Remove address_dao_transactions, use dao_events instead #297

ShiningRay opened this issue Apr 18, 2023 · 3 comments
Assignees
@zmcNotafraid
Labels
refactor

Comments

@ShiningRay
Copy link
Contributor

The dao_events tables actually contains all the information inaddress_dao_transactions
So we can directly use dao_events to establish the relationship between address and dao transactions.
@Danie0918 Danie0918 moved this to 🆕 New in CKB Explorer Apr 19, 2023
@poor-defined
Copy link
Contributor

Updated from mingchang:
It seems the impact is minimal, so no adjustments are needed.

So I put this into hold on and adjust its priority

@poor-defined poor-defined moved this from 🆕 New to 📫Hold On in CKB Explorer Dec 22, 2023
@github-actions github-actions bot mentioned this issue Jan 25, 2024
Merged
@github-actions github-actions bot mentioned this issue Feb 23, 2024
Merged
@zmcNotafraid zmcNotafraid moved this from 📫Hold On to 🏗 In Progress in CKB Explorer Dec 16, 2024
@zmcNotafraid zmcNotafraid removed their assignment Dec 16, 2024
@github-actions github-actions bot mentioned this issue Dec 20, 2024
Merged
@zmcNotafraid
Copy link
Member

zmcNotafraid commented Dec 27, 2024 •
edited
Loading

The new_dao_depositor and take_away_all_deposit event types in the Dao event are only used for daily statistics calculations, so they may be removed.

  • add unique index
  • refactor node processor logic of dao event
  • refactor revert block job logic of dao evnet
  • fix data

@zmcNotafraid
Copy link
Member

zmcNotafraid commented Jan 2, 2025 •
edited
Loading

PR: nervosnetwork/ckb-explorer#2374
nervosnetwork/ckb-explorer#2378
nervosnetwork/ckb-explorer#2390
nervosnetwork/ckb-explorer#2399

@zmcNotafraid zmcNotafraid moved this from 🏗 In Progress to 👀 Testing in CKB Explorer Jan 2, 2025
@zmcNotafraid zmcNotafraid moved this from 👀 Testing to ✅ Done in CKB Explorer Jan 2, 2025
@github-actions github-actions bot mentioned this issue Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmcNotafraid zmcNotafraid

Labels
refactor
Projects
CKB Explorer
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ShiningRay @zmcNotafraid @poor-defined @Danie0918