Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deriving New Addresses When Connecting Hardware Wallet to Neuron #426

Open
Keith-CY opened this issue Oct 22, 2024 · 0 comments
Open

Deriving New Addresses When Connecting Hardware Wallet to Neuron #426

Keith-CY opened this issue Oct 22, 2024 · 0 comments
Assignees
Labels

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Oct 22, 2024

Is your feature request related to a problem? Please describe.
Currently, when Neuron connects to a hardware wallet, it only uses the same address with the path m/purpose'/coin_type'/account' (https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-wallet/src/controllers/hardware.ts#L54), rather than m/purpose'/coin_type'/account'/change/address_index. There are two main reasons for this:

  1. Consistency with CKB-CLI:
    CKB-CLI’s default behavior is to always use the same address, limited to the account level in the path: https://github.com/Magickbase/neuron-internal/issues/1307.
  2. Optimized User Experience:
    This approach prevents funds from being scattered across multiple addresses, which would otherwise require users to sign transactions multiple times.

However, hardware wallets support HD wallet address derivation, and Bitcoin wallets already allow address derivation. Recently, some users have requested this feature(https://discord.com/channels/657799690070523914/657799690552606745/1297367214550290493), as address derivation can improve privacy.

Describe the solution you'd like

We should allow users to switch to this mode, enabling them to derive more addresses either automatically during synchronization or manually as needed.

Additional context
This feature is not high-priority, it can be scheduled for months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📌Planning
Development

No branches or pull requests

2 participants