Reproducible build

[bzz]

Thank you for sharing interesting plugin!

Right now, there does not seem to be an easy way to build the plugin locally from the sources.

It would be nice to set up a reproducible build instructions that would allow that e.g using gradle / https://github.com/JetBrains/gradle-intellij-plugin or any other way.

[linghuiluo]

@jonasmanuel can you take care of this?

[jonasmanuel]

Hi,
thank you for the suggestion @bzz
We will look into it, to see how we can improve the process 👍

[jonasmanuel]

Until we have a setup that works just from gradle:
right now we are just using intellijs built-in feature to build the plugin:

• Import the project into IntelliJ
• go to Build -> Prepare Plugin Module 'MagpieBrigdeLSPSupport' for Deployment

The Plugin Module zip should be exported to the root of the project folder.

[jonasmanuel]

In #4 you mentioned you are using the EAP version of IntelliJ.
As far as I can see, there were some significant changes made to the Platform SDK since version 2019.1.

I will look into what changed and try to support the current version of intelliJ. However I did not see any mention of the missing classes and packages in the list of incompatible API changes , so I am unsure why they would not be available any more.

[juliandolby]

One thing I noticed at one point was that I needed to build intellij community from source in order to get libraries with all the APIs that I found on the Web. If the changes are not listed, perhaps we need to do that again?

[juliandolby]

I just managed to build intellij community from github, and our plugin built with that for me. The main change I needed was an extra dependency in plugin.xml, or the plugin could not find needed classes at runtime. That is pushed.

I am currently running the plugin on IntelliJ IDEA 2020.3

[juliandolby]

Probably we will need to fix something soon, because ProjectComponent has been deprecated. For now, things seem to work, though.

[jonasmanuel]

Thanks for looking into it. Did not occur to me that building yourself would change the classes deployed in the SDK. Thats quite strange.
It also does not really seem to help with a reproducible build. I will try to use the older version in the gradle build and see if that helps it.

That is pushed.

I do not see the commit oO. Can you push it again?

[juliandolby]

i push to the 'ibm' branch

[jonasmanuel]

oh ok

[juliandolby]

I was looking at the newly-deprecated PluginComponent, and it looks like there are new APIs that we are supposed to use: documentation

A quick look suggests the migration will not be hard, but will be a bit of tedious work.

[jonasmanuel]

As a first fix I think we can just use StartupActivity register a dispose listener to the Project to be notified of projects opening and closing.
This seems to work fine as far as I can see.
Not sure about the quickfixes though (have not completely figured out how they work in the first place tbh 😉)

I have now figured out the gradle build and with the added dependency on the java module it seems to produce a valid and deployable plugin that runs in the latest intellij.

[jonasmanuel]

Hi @bzz ,

I have now published a new release here and pushed the project with the gradle setup.
Please have a look if this solves the problems you were having. As far as I can see it should now work in intelliJ 2019.2 through to the latest EAP.

[bzz]

Sorry for the delay as it's ICSE now. Looks awesome to me, thank you for fixing this - I will take a look and get back to you here.