Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github actions to build firmware should only run if something in the firmware/ directory changes #49

Closed
angrox opened this issue Nov 11, 2020 · 0 comments · Fixed by #59
Closed

Github actions to build firmware should only run if something in the firmware/ directory changes #49

angrox opened this issue Nov 11, 2020 · 0 comments · Fixed by #59
Assignees
@1uk4sh
Labels
bug Something isn't working cicd Build and release issues or improvements

Comments

@angrox
Copy link
Collaborator

angrox commented Nov 11, 2020

Describe the bug
Firmware build is triggered every time a PR and/or a merge to main is done.

To Reproduce
Steps to reproduce the behavior:

  1. Make a change in a file outside of firmware/
  2. Make a PR
  3. Github Action is triggered

Expected behavior
The firmware build should only be triggered if the firmware changes
@angrox angrox added bug Something isn't working cicd Build and release issues or improvements labels Nov 11, 2020
@angrox angrox changed the title Github actions to build should only run if something in the firmware/ directory changes Github actions to build firmware should only run if something in the firmware/ directory changes Nov 11, 2020
@1uk4sh 1uk4sh self-assigned this Nov 12, 2020
@1uk4sh 1uk4sh mentioned this issue Nov 12, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1uk4sh 1uk4sh

Labels
bug Something isn't working cicd Build and release issues or improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

only run CI for firmware/ changes MaibornWolff/clean-air
2 participants
@angrox @1uk4sh