Skip to content

Commit

Permalink
[v4.y] CI: don't abort other builds when one fails error
Browse files Browse the repository at this point in the history
- Helps confirm suspected OS-specific failures.
- Normally when one build fails, most other builds already started and
  some almost complete `bundle install` / started tests.
  So it's not a big "waste" expensive to let them finish, arguably it's
  actually a waste to abort them! (sunken cost fallacy? :-)
- In case rubocop complains, while I do consider it a merge blocker,
  it's better contributor (and maintainer) experience to also see test results.
  • Loading branch information
cben committed Mar 23, 2022
1 parent 158173e commit 2742175
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
- '**'
jobs:
build:
continue-on-error: true
runs-on: ${{ matrix.os_and_command.os }}
strategy:
matrix:
Expand Down

0 comments on commit 2742175

Please sign in to comment.