New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Performance issue #4

Open

cybercamphackathon opened this issue Dec 2, 2017 · 0 comments

cybercamphackathon commented Dec 2, 2017

In java the String are immutable. So, do that is very inefficient:

String text;
text += line + "\r\n ";

The code do that in many places of the project, for example: https://github.com/borjalor/DroidSentinel/blob/master/DroidSentinel/app/src/main/java/com/example/droidsentinel/droidsentinel/LogTask.java#L237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment