Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project probably has security vulnerabilities #90

Open
tlhunter opened this issue Jun 12, 2019 · 0 comments · May be fixed by #94
Open

Project probably has security vulnerabilities #90

tlhunter opened this issue Jun 12, 2019 · 0 comments · May be fixed by #94
Labels
Security

Comments

@tlhunter
Copy link
Collaborator

tlhunter commented Jun 12, 2019 •
edited
Loading

This project most likely has security vulnerabilities. If an attacker is able to craft any string being spoken then it's likely such a string can be used for command injection.

Such security implications are probably going to change between MacOS/Linux vs Windows/Powershell.

The text and voice arguments need to be cleaned up before being passed to the commands. voice should have a strict subset of characters, and text should probably replace all special characters such as / with FORWARD SLASH.
@tlhunter tlhunter mentioned this issue Sep 26, 2019
Open
tlhunter added a commit that referenced this issue Sep 29, 2019
@tlhunter
WIP: Escaping characters sent to TTS
803530d 
- Fixes #90
- Fixes #93
- SEMVER: This is a MAJOR change, but since pre 1.0, can be a MINOR
This was referenced Sep 29, 2019
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Escaping characters sent to TTS Marak/say.js
1 participant
@tlhunter