Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It would be nice to support other MySQL compatible servers #41

Closed
sunxiaoguang opened this issue Jul 7, 2022 · 3 comments
Closed

It would be nice to support other MySQL compatible servers #41

sunxiaoguang opened this issue Jul 7, 2022 · 3 comments

Comments

@sunxiaoguang
Copy link
Contributor

Looks like we can't connect to other types of MySQL compatible servers at this time. I have created a PR to let users configure their server name to MySQL.
@sunxiaoguang sunxiaoguang mentioned this issue Jul 7, 2022
Merged
@grooverdan
Copy link
Member

I think a better strategy is to remove the mariadb client based connector and use a real python connector (like #27).

@robertbindar
Copy link
Collaborator

New MariaDBClient implementation based on a proper python connector (plus config option) is the ideal solution. Given nobody probably has time to implement that now, @sunxiaoguang fix is just excellent and highly appreciated!

@LinuxJedi
Copy link
Contributor

Closing this as #40 is merged. But we should definitely consider #27 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@grooverdan @LinuxJedi @robertbindar @sunxiaoguang