Why is DialogHost.GetInstance private ?

[aohashi084]

I want to change the CloseOnClickAway property depending on parameters.

public static class MyDialog
{
    public static string RootDialogIdentifier { get; set; } = "RootDialog";

    public static void ShowMessage(string title, string message, bool closeOnClickAway)
    {
        var host = DialogHost.GetInstance(RootDialogIdentifier);  // this is private
        host.CloseOnClickAway = closeOnClickAway;

        var view = new MessageBox
        {
            DataContext = new MessageBoxVm { Title = title, Message = message }
        };
        host.ShowDialog(view);
    }
}

Is there another way to implement this?

[Keboo]

This is something that could probably be made public. When it was added there was not a use-case for it being public and the implementation has changed a few times, so it was kept private to avoid any changed being a breaking change. But I think now, it would be fine to change it.

[aohashi084]

Thank you.
I have resolved the issue by reflection as follows, but will create a pull request if there is demand.

private static DialogHost FindDialogHost(string identifier)
{
    var type = typeof(DialogHost);
    var getInstance = type.GetMethod("GetInstance", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Static);
    return getInstance.Invoke(null, new object[] { identifier }) as DialogHost;
}