Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumericUpDown not focusable by pressing tab #3654

Open
corvinsz opened this issue Aug 21, 2024 · 2 comments
Open

NumericUpDown not focusable by pressing tab #3654

corvinsz opened this issue Aug 21, 2024 · 2 comments
Labels
bug evaluation required Items is pending review or evaluation by the team

Comments

@corvinsz
Copy link
Contributor

Bug explanation

When trying to focus the NumericUpDown control via tab (or shift+tab) the TextBox is not focused, but rather the entire control itself:
NumericUpDownFocusBug

Version

5.1.0
@corvinsz corvinsz added bug evaluation required Items is pending review or evaluation by the team labels Aug 21, 2024
corvinsz added a commit to corvinsz/MaterialDesignInXamlToolkit that referenced this issue Aug 21, 2024
@corvinsz
fixes MaterialDesignInXAML#3654 set IsTabStop in to False in the defa…
055565a 
…ult NumericUpDown control
@jamesport079
Copy link

IsTabStop=false solves the annoying useless tabStop on the outer part of the control. However when you programmatically focus the NumericUpDown control, it is the outer control that gets the focus, not the textbox part which in my opinion should be the default.

corvinsz added a commit to corvinsz/MaterialDesignInXamlToolkit that referenced this issue Aug 22, 2024
@corvinsz
focus PART_TextBox of NumericUpDown control if it gets focus and enab…
14833f0 
…le moving focus with tab (and shift+tab) MaterialDesignInXAML#3654. Also removed the IsTapStop on the Template because that is not longer needed
@corvinsz
Copy link
Contributor Author

@jamesport079 I agree with you. I opened a PR #3656 that should make the NumericUpDown control focusable via code and keyboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug evaluation required Items is pending review or evaluation by the team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesport079 @corvinsz