-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend]: Implement pagination to the App #2
Comments
@Mayank0255 Can you assign this issue to me? |
@devanshiv123 sure, go ahead |
@Mayank0255 I am getting the the following error while setting up project(after npm run dev) |
@devanshiv123 |
@devanshiv123 |
@Mayank0255 Yes I think its exported correctly |
@devanshiv123 Can you look into it if possible? I will also try to figure it out. Btw I am assuming that you haven't changed anything in the code right now? |
@Mayank0255 No I havn't made any changes I have just made the setup till now. I will try to figure out, maybe an issue with dependency. |
@devanshiv123 yes, correct, it's been sometime time there had been any changes so might be some functions or methods may have depreciated with the new versions |
@devanshiv123 any updates? |
@Mayank0255 I am still getting those errors. I have tried for a day but maybe something is wrong. For now you can unassign me from the issue, I will first try to setup correctly and then take up any other issue. |
@devanshiv123 Oh, ok Any other reason that you wanna work on some other issue? |
@Mayank0255 No nothing as such, I will surely try to contribute if I get the setup properly after resolving errors. |
@devanshiv123 Cool |
@alceil can you please clarify that from which issue are you willing to begin? @kunalkumar007 kindly give the person 1 day to get back to us, if he decides to take up this issue then I can recommend you to take up #31 this issue, which might be something new and for which a guide has also been referred. If he decides to take up anyother issue then I would love you to be part of this issue. If @alceil doesn't gives us an update by the EOD then I can happily assign this to @kunalkumar007 as I am looking for some active participants as well :-) |
Is this still active ? Can I work on it |
Yes it is active, @kunalkumar007 is also willing to work on this, so @kunalkumar007 would you like to work with @jigmet123 on this or do you want to work on this separately? |
As more developers are interested to work on this issue, I would try another issue. |
@kunalkumar007 sure, kindly comment on that particular issue so that I can assign you that. |
@jigmet123 I am then assigning this issue to you, is that ok? |
@Mayank0255 sure I will take this |
@jigmet123 Cool. Looking forward to a PR soon!! |
@jigmet123 Any updates on the progress? Let me know if you get stuck anywhere |
@Mayank0255 In case this doesn't make any progress I'd be happy to take over. |
@luko0610 Cool, let's wait for sometime if the person replies, I will assign it to you if the person doesn't replies. |
Sounds good. Thanks. |
@luko0610 Okay so @jigmet123 two days has completed since I asked him about the updates. Should I assign it to you then? And may I ask that approximately after how much time can I expect a PR? |
Yes, please. Should be done in about two days. |
@luko0610 Great, looking forward to it 🎉 |
@Mayank0255 I'm currently at it. Frontend pagination component is nearly done (still needs some style improvements). |
Great progress @luko0610 , Can you elaborate on the part of server side pagination? If pagination has been setup on the frontend then what will you be doing in the backend? |
@Mayank0255 A solution for this issue would be to do the pagination server side. That means when fetching the entries from the backend we always send the currentPage and pageSize we want returned, and then only get sent back entries we want to currently show in the frontend. I would for now implement it client side, but I could of course make another PR to add server side pagination later on. |
@Mayank0255 I have created a PR (#57) . I created the pagination component and added it to the pages as described. Thank you. |
@luko0610 I think it's a good idea, I have two things to ask about it,
I would request you to make a an issue related to this on the backend repo, and then add a brief description related to it so that I can assign you that and the project management runs smoothly. |
|
@luko0610 cool, make an issue there then, will assign it to you |
feat(#2): implement pagination component and add it to pages
Add pagination in the front-end on pages:
The pagination for the HomePage and QuestionsPage should look similar to this:
Don't add the counts per page thing, if possible you can go ahead or else the pagination will begin after
10 PostItem Components
And for TagsPage and UsersPage, it should look like this:
The pagination should begin after
12 TagPanel Components
Kindly check for all the cases file paginating like on going forward how the paginate component should look like and all.
Feel free to tag me if there's any issue 😄
The text was updated successfully, but these errors were encountered: