More Cauldrons extracting fluids

[zjael]

Issue description:
Extracting fluids inside compact machine, causes server to crash, and will continue to crash on startup, until either fluid tank or controller is removed.

Steps to reproduce:

• Launch SkyFactory 4 with no plugins
• Extract lava and insert into any fluid tank inside a compact machine, using xnet controller.

Versions:

• Minecraft: 1.12.2
• Forge: 14.23.5.2831
• SkyFactory Modpack: 4.0.5
• McJtyLib: 3.1.1
• XNet: 1.7.6

[josephcsible]

Why did you edit out the "Relevant logs, if any:" section instead of posting your crash log? Please post it. Also, see if the bug happens with no mods installed except for XNet, Compact Machines, whatever mod provided the fluid tank you used, and their dependencies.

[zjael]

Hmm can't reproduce crash from a tank to a tank, it only crashes with this setup:
Cobblestone generator connected to an automated user/auto clicker -> cauldron
Extracting lava from cauldron to anything seems to cause a crash, like fluid tank or compact machine tunnel.

Edit: Did some tests, it seems to do with inserting lava, and extracting power to and from an, Geothermal generator at the same time, with the above setup

Log: https://pastebin.com/fK4APyh9
Crash log: https://pastebin.com/CLqQ5pHT

Seems to be related to: #340

[josephcsible]

There are still over 200 mods in that crash report. Can you try to reproduce the problem with a more minimal set?

[zjael]

Okay, forget everything about compact machines

Steps to reproduce:
Setup as such:

Then just spam the cauldron with lava buckets

Crash log: https://pastebin.com/Xck4nDG3

[josephcsible]

I just pushed c18b176 to help troubleshoot this. Install this build of XNet, then get it to crash and post the new crash report: xnet-1.12-1.7.6+gc18b176.zip

[josephcsible]

Never mind, I managed to reproduce it myself. The key is that it only happens when the generator is nearly full, such that it has room for some lava, but not for a full bucket's worth. (Here's what I got: Error: java.lang.NullPointerException: knightminer.inspirations.recipes.tank.CauldronTank misbehaved! handler.drain(600, true) returned null, even though handler.drain(1000, false) did not)

[josephcsible]

Also, it has nothing to do with More Cauldrons; it would happen even with a vanilla cauldron. The real trigger is the custom fluid handler that Inspirations installs on cauldrons.

[josephcsible]

I reported this at KnightMiner/Inspirations#124 but it was closed without action. I'll put in a workaround on our side for it.