Launching on Void Linux doesn't do anything #453
Comments
|
Can you try with development branch? 0.4 is some changes back and it might be something we've fixed already. There's no need to build, just clone directory and then run |
|
Yes. It works on Tried with these changes: diff --git a/template b/template
index 81adf03..e567231 100644
--- a/template
+++ b/template
@@ -3,7 +3,7 @@ pkgname=sunflower
version=0.4
revision=1
_version_append_revision="-62"
-wrksrc="Sunflower-${version}${_version_append_revision}"
+wrksrc="Sunflower-develop"
build_style=python3-module
make_install_args="--optimize=1 --skip-build"
hostmakedepends="libnotify python3-setuptools python3-gobject gtk+3-devel python3-chardet"
@@ -13,6 +13,6 @@ short_desc="Small, customizable dual-panel file manager with support for plugins
maintainer="reback00 <[email protected]>"
license="GPL-3.0-or-later"
homepage="https://sunflower-fm.org"
-distfiles="https://github.com/MeanEYE/Sunflower/archive/${version}${_version_append_revision}.tar.gz"
-checksum=76f6e16a8e2761a13cfde56c5ee3625afd7e7286942ef75d67eca65384214b14
+distfiles="https://github.com/MeanEYE/Sunflower/archive/develop.tar.gz"
+checksum=@43b8109f3cb0f4a1d8957f091d124cdee4a3a31b0e2aff74df879641f429503e
python_version=3 |
|
There is an update about the path error I got for diff -Nur Sunflower-develop/sunflower/gui/main_window.py Sunflower-develop-b/sunflower/gui/main_window.py
--- Sunflower-develop/sunflower/gui/main_window.py 2020-10-03 22:31:01.000000000 +0600
+++ Sunflower-develop-b/sunflower/gui/main_window.py 2020-10-05 17:10:16.222109533 +0600
@@ -916,13 +916,13 @@
# try loading from zip file
if os.path.isfile(sys.path[0]) and sys.path[0] != '':
archive = zipfile.ZipFile(sys.path[0])
- with archive.open('styles/main.css') as raw_file:
+ with archive.open('/usr/share/sunflower/styles/main.css') as raw_file:
provider.load_from_data(raw_file.read())
archive.close()
# load styles from a file
else:
- file_name = os.path.join(common.get_static_assets_directory(), 'styles', 'main.css')
+ file_name = os.path.join('/usr/share/sunflower/styles/main.css')
provider.load_from_file(Gio.File.new_for_path(file_name))
# apply stylesWith some trials I found out that if I only apply the first change, it doesn't work. I had to change it in the Also, Void Linux seems to only allow stable releases for their packages. Can the changes in |
|
First change you did was for Sunflower standalone. That is to say we have an option to `make standalone` and you get
single executable file which works everywhere if you have some required Python modules installed. That's why your "fix"
didn't work.
Regarding other change getting assets directory relies on Python's `sys.prefix` path. Can you start `python3` from
terminal and type:
import sys
sys.prefix
And let me know what's value of that?
--
Mladen Mijatov
Head of R&D, Way2CU
CEO, AGM Development
Key ID: 4096R/83EFD5A0 2013-08-18
|
|
On my Void Linux |
|
Hm, so does on mine. What does that build do? Is it by any chance installing using |
|
Yeah. It runs setup.py. It does it through this file because we have |
|
I tried the original release based template from the first post again and it seems to be showing the main.css message now. The issue was about failing silently, without showing any message at all and hanging the terminal session. So that particular issue seems to be fixed. I am not sure what happened. I did a manual install in the meanwhile, from Until this shows up again, I'm closing this issue and opening a new one for the main.css message. |
|
Hello, I would like to provide the log that I get when building sunflower with the template I have. Build log When executing the binary the same thing happens to me as to reback00 and I get the following: |
|
Thanks for posting this. So the main.css path issue is confirmed. This issue was for not showing any message and hanging silently on terminal. It seems to have fixed by itself. So I have opened a separate issue for this main.css message specifically: #457 Hope we can get some progress there. |
|
It wasn't fixed by itself. Few days ago I pushed few patches which are addressing locations of static assets. Those are affecting this for sure. Setup.py was and is our weak spot. I mangled up the first version from what I could find online, then few community members contributed and few PRs finished it off. In other words, Setup.py is not reliable nor should be used if I have any saying in this. Making a dedicated installation script or package is far smarter idea. That style, splash image for about window, window icons, etc. All reside in different directories as static assets and I didn't manage to find a standardized and proper way of installing those through setup.py. If you folks have any tips for me, I'd be more than willing to try and make it right, but right now it seems fixing setup.py for one system breaks it in other 2. |
But I thought I tried with a release archive for
Then maybe I should try to apply a patch to hardcode the path until #457 is fixed. |
|
Ah I thought you were using develop branch. Its possible that configuration
files have soemething to do with behavior or perhaps environment got
changed.
…On Wed, Oct 7, 2020, 22:12 reback00 ***@***.***> wrote:
It wasn't fixed by itself. ... I mangled up the first version from what I
could find online, then few community members contributed and few PRs
finished it off.
But I thought I tried with a release archive for 0.4-62. As far as I
know, once a release gets out it stays like that (I mean it does not
automatically update from master). My logic tells me it should result in
the hang behavior because the checksum is also the same as before.
That style, splash image for about window, window icons, etc. All reside
in different directories as static assets and I didn't manage to find a
standardized and proper way of installing those through setup.py.
Then maybe I should try to apply a patch to hardcode the path until #457
<#457> is fixed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#453 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOSWKR7GMQICMGAUZ3FJRTSJTDTVANCNFSM4SDEWTCA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am trying to create a package for Sunflower to be used in Void Linux. I've got to this template so far:
It builds just fine. But when I install the package and launch sunflower it doesn't show anything. If I run
sunflowerfrom terminal it doesn't show any message, gets stuck. Pressing Ctrl+C doesn't even work. I have to close the terminal tab. Am I doing anything wrong? Maybe any missing dependencies?EDIT: Having
build_style=python3-moduleruns it through this file.To test on Void Linux
The text was updated successfully, but these errors were encountered: