Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line formatting issues #242

Open
Blaziken257 opened this issue Apr 13, 2024 · 1 comment
Open

Line formatting issues #242

Blaziken257 opened this issue Apr 13, 2024 · 1 comment

Comments

@Blaziken257
Copy link
Contributor

There are occasionally issues where lines of text are too short: They don't contain as much text as they can, and as a result, the text is awkward to read, and it takes up more lines than necessary.

An example (of many) can be found here, in TextSection24, line 8:

bgb07704bgb07705bgb07706

In the spreadsheet, it is formatted like this, with a forced linebreak between "unite" and "mankind", and another between "Mother's" and "guidance":

<D1>And I was given a role to unite
mankind under the Mother's

<D1>guidance...

Whoever wrote this seemed to overestimate the length of the first line.

But this raises a few questions (not just this line, I've seen it elsewhere too):

  1. Does it hurt anything to just include everything in one line? For this example, I assume this wouldn't hurt anything:

<D1>And I was given a role to unite mankind under the Mother's guidance...

As a side note, another example of a formatting issue that is now fixed can be found in this commit -- See the removed <D3> line break at TextSection21, line 66 -- removing it fixed the text and didn't seem to cause any issues there.

  1. Was the text manually formatted in the past? It seems like the game auto-formats line breaks if there are none explicitly specified in the spreadsheet. (As a side question, does the formatting happen at build time or run time?)

  2. If there is text that requires forced linebreaks, would it be possible to automate something that checks for formatting issues like these? I know there is a text previewer somewhere, but I'm guessing that is manually done one line at a time.

@VariantXYZ
Copy link
Member

VariantXYZ commented Apr 13, 2024

Lines auto-format, I think this is included in the contributing document and first page of the spreadsheet. It happens during runtime, because text may contain variable-length strings.

The maintained formatting is usually matching the Japanese text.

We can probably create a script to catch formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants