[Bug] Valid locations to deploy aerial units are not correctly hilighted

[BlueThing00]

Brief Description *

VTOLS do not hilight areas with trees.

ASF do not hilight areas with water or trees.

3. Steps to Reproduce

1. Field aerial units on a map with water and/or trees in the deployment zone
2. Note that many areas are not correctly hilighted

Attach Files

This is a saved game which has VTOL and ASF to deploy with a deployment zone that contains both water and trees.
BugRepro.sav.gz

Severity *

Medium (Gameplay Limitation): Non-core functionality is impaired, providing a suboptimal but playable experience.

MegaMek Suite Version *

50.02

Operating System *

Windows 11

Java Version *

17.0.11

Final Verification

• I confirm this is a single, unique issue that hasn't been reported before
• I have included all necessary information and files to help reproduce this issue
• I have asked on MegaMek Discord about this issue
• I have confirmed this issue is being opened on the correct repository: MegaMek, MegaMekLab, or MekHQ

[Sleet01]

Oh, they don't highlight valid hexes for deployment purposes, got it.

[RaozSpaz]

Note that it just fails to highlight. You can still very much deploy in said hexes.

[psikomonkie]

Please, when fixing this, don’t just highlight all valid hexes. Currently it is highlighting valid ground hexes to deploy to.

It will be very difficult to find valid ground hexes for Dropships (which require 7 hexes) if this is changed without considering the current functionality.

[RaozSpaz]

An opinion/option: Highlight valid 'Airborne' hexes with a blue border. Blue is a 'border' color we already have in much like yellow so repurposing it for deployment shouldn't be too hard. Emphasis on shouldn't XD

Small Edit: I give this opinion cause after seeing Psikomonkie's statement, I think the idea of keeping it restricted to ground hexes should be left as is. So having a different color would allow us to maintain that.

[BlueThing00]

I don't have a problem with having two colors, one for ground available and one for only airborne.

I'd just like all valid hexes to be hilighted.

[Sleet01]

This is actually preventing Princess from deploying ASFs over water completely.
She uses the same code that determines if a hex is a valid ground hex to try to deploy Aerospace units on ground maps.