Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client classes being loaded on dedicated server on DynResourceGenerator #296

Closed
Alexthw46 opened this issue Jan 20, 2025 · 13 comments
Closed
Labels
1.21 Minecraft Version cause: EveryCompat Issue related to Every Compat NEOFORGE Minecraft Loader server Server-related, Not client-related

Comments

@Alexthw46
Copy link

  • supplementaries-1.21-3.0.33-beta-neoforge.jar
  • moonlight-1.21-2.17.16-neoforge.jar
  • neoforge-21.1-93.jar

https://mclo.gs/sUwYhTw

Interesting part on the bottom.

Logs error on world load, no crash since the exception is caught, when the Server startup events are fired. Upon inspection it seems that somehow the Client version of DynResourceGenerator is being used, perhaps a subscribe event / listener issue?

More likely to be library's fault than one of the mods using it as dep, but if you need the modlist spl have printed it at the start.

Unrelated, there are also little GLM errors about Supplementaries a bit above that.

@github-actions github-actions bot added 1.21 Minecraft Version NEOFORGE Minecraft Loader server Server-related, Not client-related cause: Supplementaries issue related to Supplementaries labels Jan 20, 2025
@MehVahdJukaar
Copy link
Owner

MehVahdJukaar commented Jan 20, 2025

does this just happens with just suppleentaries on?

@Alexthw46
Copy link
Author

Fair question but since it's a dedicated server issue i can't meddle freely with modlist as in general issues, may take a while to setup the stuff to check

@MehVahdJukaar
Copy link
Owner

real issue is one of my mod or one of another mod that uses dynamic generator system is registering a client reloader on server side too

@Alexthw46
Copy link
Author

noticeable other one i see that depends on selene is everycomp, which i also have to update a bit apparently

@Alexthw46
Copy link
Author

Uhm, seems with just moonlight + supp + everycomp the error doesn't pop

@Alexthw46
Copy link
Author

Nope, can't manage to reproduce on a smaller set of mods. Is there any way of dumping the list of registered reloaders, like a quick custom jar of moonlib so i can drop that on the server where it occurs?

@MehVahdJukaar
Copy link
Owner

well i can publish a version that wil throw a clear error when that is detected. should prevent erroneous regstration in the future but will still require fixing of that mod

@Alexthw46
Copy link
Author

https://mclo.gs/8KXaza0

Should be this, i updated the lib and it detected the issue in everycompat.

tried with everycompat 2.9.0 (latest currently)

@Alexthw46
Copy link
Author

Alexthw46 commented Jan 23, 2025

i believe you fixed this indev (edit, i was looking at the wrong branch) already so i'll close it, the log should point to the snippet that is classloading anyway

@Alexthw46 Alexthw46 reopened this Jan 23, 2025
@Alexthw46
Copy link
Author

https://mclo.gs/zDgVLVH

Tried everycompat 2.9.1 but didn't solve it

@MehVahdJukaar
Copy link
Owner

seems to be a bug with fuctional storage module. EC will need another update

@Alexthw46
Copy link
Author

Everycompat 2.9.2 did it

@Xelbayria
Copy link
Collaborator

FIXED in Every Compat v2.9.2

@Xelbayria Xelbayria added cause: EveryCompat Issue related to Every Compat and removed cause: Supplementaries issue related to Supplementaries labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 Minecraft Version cause: EveryCompat Issue related to Every Compat NEOFORGE Minecraft Loader server Server-related, Not client-related
Projects
None yet
Development

No branches or pull requests

3 participants