Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞]: (1.20.1) Supplementaries Basket allowing infinite uses of Potion Flasks from Ars Nouveau #1345

Open
5 tasks done
SpiderKolo opened this issue Feb 5, 2025 · 2 comments
Labels
1.20.1 Minecraft Version bug Something isn't working

Comments

@SpiderKolo
Copy link

SpiderKolo commented Feb 5, 2025

Before Continuing:

  • Check you are using the latest version of the mods and its dependencies
  • Always include a latest.log if you are crashing
  • Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue persists.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version

1.20.1-FORGE

Supplementaries Version

supplementaries-1.20-3.1.12

Moonlight Lib Version

moonlight-1.20-2.13.58-forge

Describe Issue

There are three items that all share this behaviour when put in the Lunch Basked from Supplementaries:

  • Potion Flask
  • Enchanted Potion Flask: Extend Time
  • Enchanted Potion Flask: Amplify
    The way those items work is kind of similar to Basket, albeit just for potions: You can store up to 8 potions (all must be the same potions) and you may drink from it to gain that potions effect.
    Potion Flask doesn't modify potions in any way, while Enchanted variants either extend stored potions duration or increase their level at the cost of their duration.

When those flask are put inside of the Lunch Basked, because they are drinkable items, they will be accepted into the basked, but I guess because technically we are holding Basked and not Flask itself, the code responsible for reducing the count on the Flask tries to do so on the Basked... which does nothing.
I did update to newest version of the Supplementaries and Moonlight to make sure it wasn't fixed but sadly it's not, thus me writting this bug report.
EDIT: fixed misswritting

@SpiderKolo SpiderKolo added the bug Something isn't working label Feb 5, 2025
@github-actions github-actions bot added the 1.20.1 Minecraft Version label Feb 5, 2025
@MehVahdJukaar
Copy link
Owner

Give me their id so I can blacklist them. Also idk why it wouldn't work because the way baskets work is they put an item in your hand, use it and then put it back so it should be the most compatible way ever to do things and should have caught this too

@SpiderKolo
Copy link
Author

I haven't seen my notification on message, so excuse me for delayed response.

The ID of the bottles:
ars_nouveau:potion_flask
ars_nouveau:potion_flask_amplify
ars_nouveau:potion_flask_extend_time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.1 Minecraft Version bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants