Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Snowflake logging during invocation #269

Closed
holly-evans opened this issue Oct 7, 2024 · 3 comments · Fixed by #299
Closed

Reduce Snowflake logging during invocation #269

holly-evans opened this issue Oct 7, 2024 · 3 comments · Fixed by #299
Assignees
Labels
bug Something isn't working

Comments

@holly-evans
Copy link

Description

target-snowflake emits many log entries from the snowflake.connector

To reduce this, package a default logging configuration for target-snowflake to remove these from INFO

References

@edgarrmondragon
Copy link
Member

Thanks for logging!

@edgarrmondragon edgarrmondragon self-assigned this Oct 8, 2024
@chadcampling-opteon
Copy link

Is this one just as simple as changing the logging config at https://github.com/MeltanoLabs/target-snowflake/blob/main/target_snowflake_logging.yaml to be INFO and not DEBUG as it is now?

The logging from the snowflake.connector.cursor is making my logs unreadable in cloudwatch while trying to diagnose an issue.

Happy to push a PR if I'm not missing something!

@edgarrmondragon
Copy link
Member

Is this one just as simple as changing the logging config at https://github.com/MeltanoLabs/target-snowflake/blob/main/target_snowflake_logging.yaml to be INFO and not DEBUG as it is now?

Happy to push a PR if I'm not missing something!

You actually need to package the logging configuration file, so that file won't do and we'd like to keep to output debug logs in CI here. So, #299 should do it. Can you confirm the logs are less spam-y with that?

@edgarrmondragon edgarrmondragon added the bug Something isn't working label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants