Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDKeyring class from @metamask/eth-hd-keyring should implement the Keyring type #141

Open
mikesposito opened this issue Jan 15, 2025 · 1 comment
Open

HDKeyring class from @metamask/eth-hd-keyring should implement the Keyring type #141

mikesposito opened this issue Jan 15, 2025 · 1 comment
Assignees
@mikesposito
Labels
team-wallet-framework

Comments

@mikesposito
Copy link
Member

All keyring classes should extend from this base common type.
@desi
Copy link

desi commented Jan 20, 2025 •
edited
Loading

Blocked by #92.

We believe there is at least one change needed for the type see MetaMask/utils#128. We should talk with @danroc to discuss for additional refinement.

We have at least 2 types. One in utils and one that is in the Keyring API (only used by the snap keyring). We want to reconcile those.

@mikesposito mikesposito self-assigned this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikesposito mikesposito

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@desi @mikesposito