Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul keyring's init method #145

Open
mikesposito opened this issue Jan 15, 2025 · 1 comment
Open

Overhaul keyring's init method #145

mikesposito opened this issue Jan 15, 2025 · 1 comment
Assignees

Comments

@mikesposito
Copy link
Member

Some methods on keyrings are supposed to be used to initialize them with (or without) certain parameters after construction, like generateRandomMnemonic for HDKeyring or sublitCryptoKey for the QRKeyring.

Some of these can be assimilated to a more generic init function, which is also part of our generic Keyring type which can be implemented by all supported keyrings. We should evaluate if it's possible to remove all these custom initialization methods and have an init method when needed instead.

@desi
Copy link

desi commented Jan 20, 2025

This will likely need to be broken down into multiple issues. @mikesposito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants