Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyring.signTypedData does not support V1 #225

Open
mikesposito opened this issue Feb 21, 2025 · 0 comments · May be fixed by #224
Open

Keyring.signTypedData does not support V1 #225

mikesposito opened this issue Feb 21, 2025 · 0 comments · May be fixed by #224

Comments

@mikesposito
Copy link
Member

The signTypedData method on the Keyring type has Record<string, unknown> as type for the data accepted. However, this means that the TypedDataV1` type for V1 is not supported.

As HDKeyring and SimpleKeyring support it, we should make the keyring method type wider
@mikesposito mikesposito linked a pull request Feb 21, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Keyring.signTypedData accepts types for V1 MetaMask/accounts
1 participant
@mikesposito