From faf540d8c02f50b6664cc10c22efff27955b1b6e Mon Sep 17 00:00:00 2001
From: Albert Olive <albertolivecorbella@gmail.com>
Date: Fri, 18 Oct 2024 14:34:07 +0200
Subject: [PATCH] chore: reverted code

---
 .circleci/scripts/check_mmi_trigger.sh | 42 ++++++++++++++------------
 1 file changed, 23 insertions(+), 19 deletions(-)

diff --git a/.circleci/scripts/check_mmi_trigger.sh b/.circleci/scripts/check_mmi_trigger.sh
index f8d05a37c319..267de9ee578f 100644
--- a/.circleci/scripts/check_mmi_trigger.sh
+++ b/.circleci/scripts/check_mmi_trigger.sh
@@ -14,16 +14,13 @@ PR_NUMBER=$(echo "$CIRCLE_PULL_REQUEST" | awk -F'/' '{print $NF}')
 REPO_OWNER="$CIRCLE_PROJECT_USERNAME"
 REPO_NAME=$(basename "$CIRCLE_REPOSITORY_URL" .git)
 
-# Fetch PR details and reviews using GitHub API
-API_URL="https://api.github.com/repos/$REPO_OWNER/$REPO_NAME/pulls/$PR_NUMBER"
-PR_DETAILS=$(curl -s -H "Authorization: token $GITHUB_TOKEN" "$API_URL")
-REVIEWS=$(curl -s -H "Authorization: token $GITHUB_TOKEN" "$API_URL/reviews")
-
-# Check if the API requests were successful
-if [[ -z "$PR_DETAILS" || -z "$REVIEWS" ]]; then
-  echo "Error: Unable to fetch PR details or reviews from GitHub API."
-  exit 1
-fi
+# Fetch PR details using GitHub API
+PR_DETAILS=$(curl -s -H "Authorization: token $GITHUB_TOKEN" \
+  "https://api.github.com/repos/$REPO_OWNER/$REPO_NAME/pulls/$PR_NUMBER")
+
+# Fetch submitted reviews
+SUBMITTED_REVIEWS=$(curl -s -H "Authorization: token $GITHUB_TOKEN" \
+  "https://api.github.com/repos/$REPO_OWNER/$REPO_NAME/pulls/$PR_NUMBER/reviews")
 
 # Check for label 'team-mmi'
 LABEL_EXISTS=$(jq -r '.labels[]? | select(.name == "team-mmi") | length > 0' <<< "$PR_DETAILS")
@@ -34,21 +31,28 @@ REVIEWER_REQUESTED=$(jq -r '.requested_reviewers[]? | select(.login == "mmi") |
 # Check for team reviewer 'mmi'
 TEAM_REQUESTED=$(jq -r '.requested_teams[]? | select(.slug == "mmi") | length > 0' <<< "$PR_DETAILS")
 
-# Check if 'mmi' has submitted a review
-REVIEWER_SUBMITTED=$(jq -r '.[]? | select(.user.login == "mmi") | length > 0' <<< "$REVIEWS")
+# Check if 'mmi' submitted a review
+REVIEWER_SUBMITTED=$(jq -r '.[]? | select(.user.login == "mmi") | length > 0' <<< "$SUBMITTED_REVIEWS")
 
-# Evaluate whether to run MMI tests
+# Determine which condition was met and trigger tests if needed
 if [[ "$LABEL_EXISTS" == "true" || "$REVIEWER_REQUESTED" == "true" || "$TEAM_REQUESTED" == "true" || "$REVIEWER_SUBMITTED" == "true" ]]; then
   echo "run_mmi_tests=true" > mmi_trigger.env
 
   # Log exactly which condition was met
   echo "Conditions met:"
-  [[ "$LABEL_EXISTS" == "true" ]] && echo "- Label 'team-mmi' found."
-  [[ "$REVIEWER_REQUESTED" == "true" ]] && echo "- Reviewer 'mmi' requested."
-  [[ "$TEAM_REQUESTED" == "true" ]] && echo "- Team 'mmi' requested."
-  [[ "$REVIEWER_SUBMITTED" == "true" ]] && echo "- Reviewer 'mmi' submitted a review."
-
+  if [[ "$LABEL_EXISTS" == "true" ]]; then
+    echo "- Label 'team-mmi' found."
+  fi
+  if [[ "$REVIEWER_REQUESTED" == "true" ]]; then
+    echo "- Reviewer 'mmi' requested."
+  fi
+  if [[ "$TEAM_REQUESTED" == "true" ]]; then
+    echo "- Team 'mmi' requested."
+  fi
+  if [[ "$REVIEWER_SUBMITTED" == "true" ]]; then
+    echo "- Reviewer 'mmi' submitted a review."
+  fi
 else
   echo "run_mmi_tests=false" > mmi_trigger.env
-  echo "Skipping MMI tests: No 'team-mmi' label found, and no 'MetaMask/mmi' reviewer assigned or review submitted."
+  echo "Skipping MMI tests: Neither the 'team-mmi' label was found nor a reviewer from the 'MetaMask/mmi' team was assigned."
 fi