Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] When blind signing is disabled and user attempts to sign typed data v4, unknown error displayed #29802

Open
vivek-consensys opened this issue Jan 20, 2025 · 4 comments
Assignees
Labels
hardware-ledger INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. regression-prod-12.10.1 Regression bug that was found in production in release 12.10.1 Sev2-normal Normal severity; minor loss of service or inconvenience. team-hardware-wallets type-bug

Comments

@vivek-consensys
Copy link

Build: v12.11.0

  1. Install MM Extension
  2. Recover from SRP
  3. Add hardware wallet (Ledger Stax)
  4. Add Ledger account from account list
  5. Launch MM Test dApp
  6. Connect with Ledger account
  7. Disable blind signing on Ledger device
  8. Sign typed data v4
  9. Verify error

Expected:- Result: Error: Keyring Controller signTypedMessage: Error: Ledger: Blind signing must be enabled

Actual:- Result: Error: Keyring Controller signTypedMessage: Error: Ledger: Unknown error while signing message

image.png

@vivek-consensys vivek-consensys added hardware-ledger Sev2-normal Normal severity; minor loss of service or inconvenience. team-hardware-wallets type-bug labels Jan 20, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 20, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 20, 2025
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Jan 20, 2025
@danjm danjm added the release-blocker This bug is blocking the next release label Jan 21, 2025
@danjm
Copy link
Contributor

danjm commented Jan 21, 2025

Is this issue present in v12.10.1?

@vivek-consensys vivek-consensys removed the release-blocker This bug is blocking the next release label Jan 21, 2025
@vivek-consensys
Copy link
Author

@danjm yes it is present in the v12.10.1 but not sure if it is a release blocker?

@vivek-consensys vivek-consensys added the release-blocker This bug is blocking the next release label Jan 21, 2025
@dawnseeker8
Copy link
Contributor

dawnseeker8 commented Jan 22, 2025

hi, @danjm i dont think this is release blocker since ledger device will display warning message that you need to enable blind signing.

Image

After you following ledger screen steps to go to settings and enable blind signing, and trigger typed sign v4 again, the transaction will be successfully go throught after you accept the risk of blind signing warning in ledger.

However, i will have a look how to return meaningful error message in metamask extensions side.

@MetaMask MetaMask deleted a comment Jan 22, 2025
@danjm
Copy link
Contributor

danjm commented Jan 22, 2025

If the issue is present in v12.10.1, then it is not a release blocker for v12.11.0

@danjm danjm added regression-prod-12.10.1 Regression bug that was found in production in release 12.10.1 and removed release-blocker This bug is blocking the next release labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hardware-ledger INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. regression-prod-12.10.1 Regression bug that was found in production in release 12.10.1 Sev2-normal Normal severity; minor loss of service or inconvenience. team-hardware-wallets type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

5 participants