Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: decoding_in_progress metric will not fire when redesign signature decoder is loading #29851

Open
digiwand opened this issue Jan 22, 2025 · 0 comments · May be fixed by #29852
Open

[Bug]: decoding_in_progress metric will not fire when redesign signature decoder is loading #29851

digiwand opened this issue Jan 22, 2025 · 0 comments · May be fixed by #29852
Labels
regression-prod-12.9.2 Regression bug that was found in production in release 12.9.2 type-bug

Comments

@digiwand
Copy link
Contributor

Describe the bug

decoding_in_progress metric is unreachable. This metric should be added if the decoding is loading

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

  1. Turn on simulations, redesign, and metametrics settings
  2. Create permit signature that is supported by decoding api
  3. Observe metrics

Error messages or log output



Detection stage


In production (default)


Version


12.9.2


Build type


None


Browser


Chrome


Operating system


MacOS


Hardware wallet


No response


Additional context


No response


Severity


No response

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by team


      Jan 22, 2025

    

  



    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by severity


      Jan 22, 2025

    

  



    

    

      
    

    


      

          @digiwand
digiwand




        changed the title
[Bug]: decoding_in_progress will not fire when decoder is loading

[Bug]: decoding_in_progress metric will not fire when redesign signature decoder is loading


      Jan 22, 2025

    

  



    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  regression-prod-12.9.2

  Regression bug that was found in production in release 12.9.2
 label


      Jan 22, 2025

    

  



  

  

    
  


  

      

    @digiwand
digiwand



    linked a pull request
    
      Jan 22, 2025
    

    that will
    close
    this issue





  


  

      
   Open

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                    




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    regression-prod-12.9.2

  Regression bug that was found in production in release 12.9.2
  

    type-bug









      

  

    

        

    Projects
  


        




        
  

    

      
          
        Bugs by severity
        
    

    

      

            
    Status: To be fixed

              
      

    

    

  



        
  

    

      
          
        Bugs by team
        
    

    

      

            
    Status: To be fixed

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  



      

    

  
      

  

    

      2 participants
    

    

        
          @digiwand 
        
          @metamaskbot