Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Migrating the smart transaction opt-in status failing #29869

Open
racitores opened this issue Jan 23, 2025 · 0 comments
Open

[Bug]: Migrating the smart transaction opt-in status failing #29869

racitores opened this issue Jan 23, 2025 · 0 comments
Assignees
Labels
regression-RC-12.11.0 Regression bug that was found in release candidate (RC) for release 12.11.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-transactions Transactions team type-bug

Comments

@racitores
Copy link
Contributor

racitores commented Jan 23, 2025

Describe the bug

When testing feature #28854, we have found that migration from different older version than 12.11.0 aren't getting the expected results (described in the PR)
Basically we have seen that when 12.11.0 is updated the STX value is always enabled.
We need to make sure at least next test works well to be able to ensure the feature is working:
The user has MM Extension <=12.8 installed. They submit a smart transaction (it can fail or succeed). They opted-out for STX with the STX opt-in modal. The user updates MM to 12.11. The modal is not displayed and STX are disabled.

In addition we have noticed that only v12.5.0 shows the STX info popup (where STX setting value is initially setup), while with other versions, this popup is not shown and the STX setting value is set to null (while the UI shows that is activated)

Expected behavior

with next test the STX should be deactivated after upgrading the extension
The user has MM Extension <=12.8 installed. They submit a smart transaction (it can fail or succeed). They opted-out for STX with the STX opt-in modal. The user updates MM to 12.11. The modal is not displayed and STX are disabled.

Screenshots/Recordings

No response

Steps to reproduce

  1. Install extension 12.5 / 12.7.1 / 12.8 (any of them will reproduce the issue)
  2. Open the extension, confirm that STX is activated
  3. Do a TX on mainnet
  4. Change STX setting to disable
  5. Upgrade the extension to 12.11.0
  6. Login
  7. Check the STX setting -> it is activated (should be deactivated)

Error messages or log output

Detection stage

During release testing

Version

12.11.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

sev1

@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 23, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 23, 2025
@racitores racitores added Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-transactions Transactions team release-blocker This bug is blocking the next release labels Jan 23, 2025
@metamaskbot metamaskbot added the regression-RC-12.11.0 Regression bug that was found in release candidate (RC) for release 12.11.0 label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-12.11.0 Regression bug that was found in release candidate (RC) for release 12.11.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-transactions Transactions team type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

4 participants