Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): rollback @metamask/providers to 16.1.0 due to Next.js compatibility issues #1207

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

abretonc7s
Copy link
Collaborator

Description

This PR rolls back the recent upgrade of @metamask/providers from v18.3.1 to v16.1.0 due to compatibility issues discovered with Next.js applications. This is a temporary measure until we can properly address the integration challenges as part of the upcoming multichain API deployment.

Key Changes

  • Reverted @metamask/providers dependency from ^18.3.1 to 16.1.0 in packages/sdk/package.json
  • Removed @metamask/providers from rollup external dependencies list
  • Cleaned up related circular dependency warnings in rollup configuration

Impact

This rollback:

  • Resolves immediate compatibility issues with Next.js applications
  • Returns the SDK to a known stable state
  • Postpones the providers upgrade to align with future multichain API deployment

Technical Implementation

  1. Dependency management:
    • Pinned @metamask/providers to exact version 16.1.0
    • Removed from rollup externals to ensure proper bundling
  2. Build configuration:
    • Updated rollup circular dependency allowlist
    • Simplified external dependencies configuration

Testing Instructions

  1. Test with a Next.js application to verify the fix
  2. Verify basic MetaMask provider functionality:
    • Connection
    • Transaction signing
    • Account switching
  3. Run the full SDK test suite
  4. Test in both development and production builds

Future Considerations

The @metamask/providers upgrade to v18+ will be revisited as part of the multichain API deployment, where we can properly address integration challenges and provide comprehensive migration support.

@abretonc7s abretonc7s requested a review from a team as a code owner January 28, 2025 09:39
@abretonc7s abretonc7s merged commit e498c15 into main Jan 28, 2025
2 checks passed
@abretonc7s abretonc7s deleted the ab/revertprovider branch January 28, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants