Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update Snap] Masca #1048

Open
1 of 4 tasks
Vid201 opened this issue Feb 3, 2025 · 5 comments · May be fixed by #1072
Open
1 of 4 tasks

[Update Snap] Masca #1048

Vid201 opened this issue Feb 3, 2025 · 5 comments · May be fixed by #1072

Comments

@Vid201
Copy link
Contributor

Vid201 commented Feb 3, 2025

Checklist

All items in the list below needs to be satisfied.

  • Is the summary of the change documented in this ticket?
  • Has a MetaMask Snaps team member reviewed whether the changes need to be vetted?
  • If there are changes that need to be vetted, attach a description and the relevant fixes/remediations to this issue.
  • The corresponding pull request in this repo has been merged.

Summary of changes

https://hackmd.io/@EUWvefzmQwC2UG8j0XV-PQ/ryJaaICOkx

raw diff: blockchain-lab-um/masca@a7f12ce...31568a2

since original diff is huge (>300 files) here is a PR (between the two commits) it can be found with some filters already turned on (ts, tsx), drops to 65 files to review

@khanti42
Copy link
Collaborator

khanti42 commented Feb 11, 2025

Hi @Vid201 do you want to unlist some version together with this update ? For now 1.0.0, 1.1.0 and 1.2.2 are allowlisted ?

@khanti42 khanti42 linked a pull request Feb 11, 2025 that will close this issue
@khanti42
Copy link
Collaborator

@Vid201 the CI/CD does not pass because of this error Failed to fetch snap "npm:@blockchain-lab-um/masca": Snap source code must be smaller than 64 MB.. this is because of the files folder present in npm https://www.npmjs.com/package/@blockchain-lab-um/masca?activeTab=code

cc: @Montoya

@martines3000
Copy link

@khanti42

  1. You can unlist 1.0.0 and 1.1.0.
  2. Is the 64 MB file size limit a new thing? We haven't done any new updates for quite some time now, so we are a little bit out of the loop regarding requirements and limits. The files folder is necessary, as we provide the Circuits for the ZK Proofs we are doing using Privado ID (Polygon ID)

@khanti42
Copy link
Collaborator

Just checked internally @martines3000 , the 64MB limit is enforced by chrome (MM switched to Manifest V3). There is big chance that the previous version of the Snap does not work with latest MetaMask on Chrome. However this limits applies to individual files and other devs have successfully split up big files as a workaround.

@khanti42 khanti42 pinned this issue Feb 13, 2025
@khanti42 khanti42 unpinned this issue Feb 13, 2025
@khanti42 khanti42 pinned this issue Feb 13, 2025
@khanti42 khanti42 unpinned this issue Feb 13, 2025
@martines3000
Copy link

@khanti42 Thanks for the information. I just checked on NPM and none of the files are larger than 64MB. The largest files is 46MB. Is there maybe an issue with the CI ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants