-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update Snap] Masca #1048
Comments
Hi @Vid201 do you want to unlist some version together with this update ? For now 1.0.0, 1.1.0 and 1.2.2 are allowlisted ? |
@Vid201 the CI/CD does not pass because of this error cc: @Montoya |
|
Just checked internally @martines3000 , the 64MB limit is enforced by chrome (MM switched to Manifest V3). There is big chance that the previous version of the Snap does not work with latest MetaMask on Chrome. However this limits applies to individual files and other devs have successfully split up big files as a workaround. |
@khanti42 Thanks for the information. I just checked on NPM and none of the files are larger than 64MB. The largest files is |
Checklist
All items in the list below needs to be satisfied.
Summary of changes
https://hackmd.io/@EUWvefzmQwC2UG8j0XV-PQ/ryJaaICOkx
raw diff: blockchain-lab-um/masca@a7f12ce...31568a2
since original diff is huge (>300 files) here is a PR (between the two commits) it can be found with some filters already turned on (ts, tsx), drops to 65 files to review
The text was updated successfully, but these errors were encountered: