Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest file should be localizable #1508

Closed
Montoya opened this issue Jun 15, 2023 · 3 comments
Closed

Manifest file should be localizable #1508

Montoya opened this issue Jun 15, 2023 · 3 comments
Assignees
@hmalik88
Labels
snaps-prioritized-2023-oct type-research A research task.

Comments

@Montoya
Copy link
Collaborator

Montoya commented Jun 15, 2023 •
edited
Loading

Strings in manifest file should be localizable

Research whether this can be done with the current manifest version 0.1 or if it requires breaking changes and should be done in 0.2 (if it makes for a better API, we can bump the version)
@Montoya Montoya added the type-research A research task. label Jun 15, 2023
@FrederikBolding
Copy link
Member

Hey team! Please add your planning poker estimate with Zenhub @Mrtenz @david0xd @GuillaumeRx @hmalik88

@kenhkan
Copy link

kenhkan commented Oct 10, 2023

From standup:

  • Frederik: There may be overlap with File API

@kenhkan
Copy link

kenhkan commented Nov 7, 2023

From standup: E2E test update and doc needed

@Mrtenz Mrtenz mentioned this issue Nov 21, 2023
Merged
13 tasks
hmalik88 added a commit to MetaMask/metamask-extension that referenced this issue Mar 15, 2024
@Mrtenz @metamaskbot @hmalik88
Add support for localised Snap manifests (#21909)
b3b5ef6 
## **Description**

This adds support for localised Snap manifests. Instead of getting the
Snap name from the subject metadata controller, I've added a new
selector which returns the localised manifest.

Related to MetaMask/snaps#1508.

## **Manual testing steps**

1. Install `npm:@metamask/localization-example-snap` from test-snaps.
2. Make sure the proper name and description is shown everywhere.

## **Screenshots/Recordings**

<img width="472" alt="image"
src="https://github.com/MetaMask/metamask-extension/assets/7503723/03ce5e0a-a43a-4f5d-be91-ef75b15323ba">

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <[email protected]>
Co-authored-by: Hassan Malik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmalik88 hmalik88

Labels
snaps-prioritized-2023-oct type-research A research task.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Montoya @kenhkan @FrederikBolding @Mrtenz @hmalik88