Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(snaps-controllers): @metamask/object-multiplex@^1.2.0->^2.0.0 #1927

Closed
wants to merge 2 commits into from
Closed

deps(snaps-controllers): @metamask/object-multiplex@^1.2.0->^2.0.0 #1927

wants to merge 2 commits into from

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Nov 8, 2023 •
edited
Loading

  • @metamask/snaps-controllers: BREAKING: Bump @metamask/object-multiplex from ^1.2.0 to ^2.0.0

Blocking

@legobeat legobeat requested a review from a team as a code owner November 8, 2023 00:41
@legobeat legobeat mentioned this pull request Nov 8, 2023
Merged
1 task
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Nov 8, 2023
@socket-security Socket Security
Copy link

socket-security bot commented Nov 8, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/object-multiplex 2.0.0 None +0 13.2 kB lgbot

@legobeat legobeat marked this pull request as draft November 8, 2023 00:49
@socket-security Socket Security
Copy link

socket-security bot commented Nov 8, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat legobeat force-pushed the deps-snaps-controllers-object-multiplex-2 branch 3 times, most recently from 7ae0d09 to 7fb2030 Compare November 8, 2023 01:46
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a14e3d) 96.13% compared to head (439e14d) 96.13%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1927   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files         261      261           
  Lines        6062     6062           
  Branches      989      989           
=======================================
  Hits         5828     5828           
  Misses        234      234

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

FrederikBolding
FrederikBolding reviewed Nov 8, 2023
View reviewed changes
packages/snaps-controllers/package.json
@@ -45,7 +45,7 @@
"@metamask/approval-controller": "^4.0.0",
"@metamask/base-controller": "^3.2.0",
"@metamask/json-rpc-engine": "^7.1.1",
"@metamask/object-multiplex": "^1.2.0",
"@metamask/object-multiplex": "^2.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legobeat Can we bump this across all the snaps monorepo packages?

Copy link
Contributor Author

@legobeat legobeat Nov 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is what will be done eventually. However, it seems to imply quite a bit more (update of providers and some further changes?) when done in snaps-execution-environment:

https://github.com/MetaMask/snaps/actions/runs/6792674292/job/18466373634

https://github.com/legobeat/snaps-monorepo/pull/5/checks

So this PR currently aims at sidestepping that for the moment in order to allow getting @metamask/providers into @metamask/keyring-api.

Think it's worth pushing for doing the full update across the board in one larger update instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our Yarn constraints require that we use the same dependency versions across all packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: I am considering inserting a temporary exception for that, here, until @metamask/snaps-execution-environment is also bumped.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm could be that providers v14 needs some more attention to bump 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1938 (comment)

@legobeat legobeat force-pushed the deps-snaps-controllers-object-multiplex-2 branch 2 times, most recently from 7b186ba to ea118c7 Compare November 14, 2023 05:06
@legobeat legobeat marked this pull request as ready for review November 14, 2023 05:24
@legobeat legobeat force-pushed the deps-snaps-controllers-object-multiplex-2 branch from 7ccf160 to 3c03a95 Compare November 14, 2023 05:26
@legobeat
Copy link
Contributor Author

legobeat commented Nov 14, 2023 •
edited
Loading

Draft WIP for also bumping the same dependency in @metamask/execution-environments (which would again remove the need for the yarn-constraints exception introduced here):

@legobeat legobeat mentioned this pull request Nov 14, 2023
Open
@legobeat legobeat requested a review from mcmire November 14, 2023 06:18
@legobeat
deps(snaps-controllers): @metamask/object-multiplex@^1.2.0->^2.0.0
5bfea16
@legobeat
chore: add exception to constraints for consistent dependency range f…
439e14d 
…or @metamask/object-multiplex

- @metamask/object-multiplex temporarily different versions in @metamask/snaps-controllers(^2.0.0) vs @metamask/snaps-execution-environments(^1.2.0)
@legobeat legobeat force-pushed the deps-snaps-controllers-object-multiplex-2 branch from 3c03a95 to 439e14d Compare November 14, 2023 10:23
@legobeat legobeat requested a review from a team November 14, 2023 10:32
@FrederikBolding
Copy link
Member

Closing in favor of #1964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

@Mrtenz Mrtenz Awaiting requested review from Mrtenz

@mcmire mcmire Awaiting requested review from mcmire

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @FrederikBolding @Mrtenz