Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @metamask/providers from 13.0.0 to 14.0.0 #1938

Closed
wants to merge 3 commits into from
Closed

Bump @metamask/providers from 13.0.0 to 14.0.0 #1938

wants to merge 3 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 9, 2023 •
edited
Loading

Bumps @metamask/providers from 13.0.0 to 14.0.0.

Release notes

Sourced from @​metamask/providers's releases.

14.0.0

Changed

  • BREAKING: Update to streams3 API (#288)
    • Update extension-port-stream from ^2.1.1 to ^3.0.0
      • Force subdependency readable-stream to ^3.6.2 in resolutions
    • Update json-rpc-middleware-stream from ^4.2.3 to ^5.0.1
    • Update @metamask/object-multiplex from ^1.3.0 to ^2.0.0
    • Add direct dependency on readable-stream@^3.6.2
    • Replace internal usage of stream with readable-stream

13.1.0

Added

  • Add support for EIP-6963 (#263)
    • initializeProvider() params object now accepts an optional providerInfo property with a value of EIP6963ProviderInfo object
    • Add eip6963AnnounceProvider() which supports a wallet by announcing a provider through the eip6963:announceProvider event and re-announcing the provider whenever an eip6963:requestProvider event is received
    • Add eip6963RequestProvider() which supports a dapp by dispatching an eip6963:requestProvider event and invoking a callback for each eip6963:announceProvider event received
    • Add EIP6963AnnounceProviderEvent type
    • Add EIP6963ProviderDetail type
    • Add EIP6963ProviderInfo type
    • Add EIP6963RequestProviderEvent type
Changelog

Sourced from @​metamask/providers's changelog.

[14.0.0]

Changed

  • BREAKING: Update to streams3 API (#288)
    • Update extension-port-stream from ^2.1.1 to ^3.0.0
      • Force subdependency readable-stream to ^3.6.2 in resolutions
    • Update json-rpc-middleware-stream from ^4.2.3 to ^5.0.1
    • Update @metamask/object-multiplex from ^1.3.0 to ^2.0.0
    • Add direct dependency on readable-stream@^3.6.2
    • Replace internal usage of stream with readable-stream

[13.1.0]

Added

  • Add support for EIP-6963 (#263)
    • initializeProvider() params object now accepts an optional providerInfo property with a value of EIP6963ProviderInfo object
    • Add eip6963AnnounceProvider() which supports a wallet by announcing a provider through the eip6963:announceProvider event and re-announcing the provider whenever an eip6963:requestProvider event is received
    • Add eip6963RequestProvider() which supports a dapp by dispatching an eip6963:requestProvider event and invoking a callback for each eip6963:announceProvider event received
    • Add EIP6963AnnounceProviderEvent type
    • Add EIP6963ProviderDetail type
    • Add EIP6963ProviderInfo type
    • Add EIP6963RequestProviderEvent type
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner November 9, 2023 06:27
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 9, 2023
@socket-security Socket Security
Copy link

socket-security bot commented Nov 9, 2023 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/providers 13.0.0...14.0.0 None +8/-8 313 kB metamaskbot

@socket-security Socket Security
Copy link

socket-security bot commented Nov 9, 2023 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author extension-port-stream 3.0.0

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 9, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

6 similar comments
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 9, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 9, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 9, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 9, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 10, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 10, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@FrederikBolding
Copy link
Member

I tried running this locally with updated LavaMoat policies and it seems that this latest version sometimes blows up with "premature close", breaking our tests. Not entirely sure how yet 🤔

cc @legobeat @Mrtenz

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 10, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

4 similar comments
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 10, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 10, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 10, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 10, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@legobeat
Copy link
Contributor

legobeat commented Nov 12, 2023 •
edited
Loading

I tried running this locally with updated LavaMoat policies and it seems that this latest version sometimes blows up with "premature close", breaking our tests. Not entirely sure how yet 🤔

cc @legobeat @Mrtenz

FWIW I have a WIP which bumps @metamask/providers, @metamask/object-multiplex, and moves from stream to readable-stream over at https://github.com/legobeat/snaps-monorepo/tree/deps-metamask-providers-14 (legobeat#5)

Same error there, still.

@legobeat legobeat mentioned this pull request Nov 12, 2023
Closed
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 13, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

4 similar comments
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 13, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 14, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 14, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 14, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @FrederikBolding
Bump @metamask/providers from 13.0.0 to 14.0.0
f3955f0 
Bumps [@metamask/providers](https://github.com/MetaMask/providers) from 13.0.0 to 14.0.0.
- [Release notes](https://github.com/MetaMask/providers/releases)
- [Changelog](https://github.com/MetaMask/providers/blob/main/CHANGELOG.md)
- [Commits](MetaMask/providers@v13.0.0...v14.0.0)

---
updated-dependencies:
- dependency-name: "@metamask/providers"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@FrederikBolding FrederikBolding force-pushed the dependabot/npm_and_yarn/main/metamask/providers-14.0.0 branch from 00bf956 to f3955f0 Compare November 15, 2023 15:56
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (27fe061) 96.15% compared to head (ba8de5b) 96.03%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1938      +/-   ##
==========================================
- Coverage   96.15%   96.03%   -0.13%     
==========================================
  Files         263      263              
  Lines        6086     6127      +41     
  Branches      989      989              
==========================================
+ Hits         5852     5884      +32     
- Misses        234      243       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding
Copy link
Member

This dependency has been bumped elsewhere.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 17, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/main/metamask/providers-14.0.0 branch November 17, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrederikBolding @legobeat