Add row and address component #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/row-components
branch
from
0165b16 to
6b4039c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1968 +/- ##
==========================================
+ Coverage 95.99% 96.01% +0.01%
==========================================
Files 263 265 +2
Lines 6149 6172 +23
Branches 989 990 +1
==========================================
+ Hits 5903 5926 +23
Misses 246 246 ☔ View full report in Codecov by Sentry. |
FrederikBolding
force-pushed
the
fb/row-components
branch
from
4b6e353 to
db1fd12
Compare
Mrtenz
reviewed
Nov 16, 2023
FrederikBolding
force-pushed
the
fb/row-components
branch
from
9d92a39 to
4489d23
Compare
Mrtenz
reviewed
Nov 17, 2023
Mrtenz
reviewed
Nov 17, 2023
Co-authored-by: Maarten Zuidhoorn <[email protected]>
FrederikBolding
force-pushed
the
fb/row-components
branch
from
6c9eb50 to
dd4f40c
Compare
Mrtenz
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new row UI component for improving the layout of custom UIs alongside an address component that can be used inside this row.
Also updates the transaction insight example snap to use these new components and moves some code to
snaps-sdkto support validation of the components.Progresses https://github.com/MetaMask/MetaMask-planning/issues/1570