Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few issues with passing non-serializable JSON #1974

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

FrederikBolding
Copy link
Member

AbstractExecutionService will now properly guard against passing invalid JSON-RPC requests and BaseSnapExecutor will try to respond with an error if it receives an invalid JSON-RPC request that is deemed valid enough to respond.

@FrederikBolding FrederikBolding requested a review from a team as a code owner November 20, 2023 09:32
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2143331) 95.99% compared to head (537815c) 96.04%.
Report is 2 commits behind head on main.

❗ Current head 537815c differs from pull request most recent head bf4d6b6. Consider uploading reports for the commit bf4d6b6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
+ Coverage   95.99%   96.04%   +0.04%     
==========================================
  Files         263      265       +2     
  Lines        6149     6175      +26     
  Branches      989      992       +3     
==========================================
+ Hits         5903     5931      +28     
+ Misses        246      244       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding force-pushed the fb/json-serializable-errors branch from 537815c to b39d1fa Compare November 20, 2023 10:59
@FrederikBolding FrederikBolding merged commit ddbc1b6 into main Nov 20, 2023
136 checks passed
@FrederikBolding FrederikBolding deleted the fb/json-serializable-errors branch November 20, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants