Package api.addFiles accept wildcards / folders

[raix]

Hugo Magalhaes: developing a application using the method suggested at http://www.matb33.me/2013/09/05/meteor-project-structure.html, so I have a package per feature and all the packages have the following structure:

-> client
    |-> sub_folder
    |   |-> file_1.js
    |   |->    ...
    |   |-> file_n.js
    |-> file_1.js
    |->    ...
    |-> file_n.js
-> lib
    |-> sub_folder
    |   |-> file_1.js
    |   |->    ...
    |   |-> file_n.js
    |-> file_1.js
    |->    ...
    |-> file_n.js
-> server
    |-> sub_folder
    |   |-> file_1.js
    |   |->    ...
    |   |-> file_n.js
    |-> file_1.js
    |->    ...
    |-> file_n.js

Trying to find a way to add all files from each folder (and sub-folder in the following way):

api.add_files(["client/*","client");
api.add_files(["lib/*", ["client", "server"]);
api.add_files(["server/*","server");

[raix]

+1
Could be a better pattern when control files arrive?

[HugoMag]

+1

[IstoraMandiri]

👍

[dandv]

Great idea! (and pretty obvious... hey @ekatek)

[dcsan]

there is something like this

but it got confusing when using PACKAGE_DIRS to load files while in local dev mode.

packages in production have the "author:package" prefix when bundled but path.resolve(".") seems to work for this.

"client/* would be soo much cleaner!

[cvrebert]

So, someone should file an issue upstream?

[mitar]

+1

[mitar]

So, someone should file an issue upstream?

This is a feature request, there is no place to file this upstream.

[mitar]

It would be also great if package could traverse directories, so that one would not have to hard-code the paths but allow self-discovery: meteor/meteor#2626

[awgneo]

+1

[raix]

PR added, more for discussion - you are wellcome to join in working on the pr. raix:package-api-addfiles-accept-wildcards#4088

Some of the comments are off talking about Arrays, needs tests+documentation writing before it can be merged - but let's get a "go" from core before polishing.

At the moment its not recursive - but we could replace the fs.readdirSync with a fs.readdirRecursiveSync fictive name

Comments / ideas etc. are welcome - also please clone/checkout the branch and se if its working.

Kind regards Morten

[fabyeah]

+1

[thpham]

+1 really urgently needed !

[AddoSolutions]

+1

[maxenceC]

Any update on this ?

[omidahourai]

+1

[wilau2]

+1
updates ?

[mikeifomin]

@wilau2 use ecmascript imports

example in coffeescript

{ Template } = require 'meteor/templating'

require './someTemplate.html'
require './someTemplate.scss'

Template.someTemplate.onCreated ->
   # do some 

So in Meteor 1.3+ packages You does not actual use api.addFile for all of templates/styles

Just create a single entrypoint in pacakge.js

api.mainModule('main.coffee');

[ahmedtabrez]

👍

[stefanocudini]

+1

[stefanocudini]

It's a good temporary solution?

Package.onUse(function(api) {
  var path = Npm.require('path'),
      glob = Npm.require('glob'),
      files = glob.sync('client/**/*js', {cwd: path.join(path.resolve('.'), 'packages'));
  api.addFiles(files, ['client']);
});