Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Grant-CsTeamsAppPermissionPolicy.md #12450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

srimantabagchi
Copy link
Contributor

@srimantabagchi srimantabagchi commented Jan 13, 2025

Copy link

Learn Build status updates of commit fead56b:

💡 Validation status: suggestions

File Status Preview URL Details
teams/teams-ps/teams/Grant-CsTeamsAppPermissionPolicy.md 💡Suggestion View (teams-ps) Details

teams/teams-ps/teams/Grant-CsTeamsAppPermissionPolicy.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'guptaashish' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@michbrown-png michbrown-png added the Sign off The pull request is ready to be reviewed and merged by PubOps label Jan 16, 2025
@aditisrivastava07 aditisrivastava07 self-assigned this Jan 16, 2025
@aditisrivastava07 aditisrivastava07 added the In review PubOps is reviewing the pull request label Jan 16, 2025
@aditisrivastava07
Copy link
Contributor

aditisrivastava07 commented Jan 16, 2025

Hi @srimantabagchi,

Following are the blocking issues that need to be resolved before we can merge:

  • Resolve the merge conflict and re-submit the PR for review.

teams/teams-ps/teams/Grant-CsTeamsAppPermissionPolicy.md

  • Fix the suggestion in the validation table. Replace the ms.author with a valid alias.
  • Line 20: Add period at the end of sentence.

Reference

Criteria used for pull request reviews

Blocking


After you resolve the blocking issues, remove the Back to submitter label and add the Sign off label again.

If you need help resolving issues in this PR, post your question in the Ask an Admin Teams Channel.

Thanks, Aditi

@aditisrivastava07 aditisrivastava07 added Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates and removed In review PubOps is reviewing the pull request Sign off The pull request is ready to be reviewed and merged by PubOps labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants