Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter does not work #159

Open
spietrek opened this issue Aug 18, 2015 · 13 comments
Open

Linter does not work #159

spietrek opened this issue Aug 18, 2015 · 13 comments

Comments

@spietrek
Copy link

I am having an issue where the linter extension does not work. I have JSCS and JSHint loaded. The linter will work only occasionally. Generally, I need to restart Brackets a bunch of times with and without extensions in order for it to activate.

"language": {
"javascript": {
"linting.prefer": [
"JSHint",
"JSCS"
],
"linting.usePreferredOnly": true
}
},
"interactive-linter.javascript": [
"jscs",
"jshint"
],
"interactive-linter.delay": 1000,
"interactive-linter.html": [
"htmlhint"
],

The other extensions I have loaded include:

  1. AngularJS Code Hints
  2. Brackets Beautify
  3. Brackets Bower
  4. Brackets Commands Quick Search
  5. Brackets Css Color Preview
  6. Brackets Dash
  7. Brackets Git
  8. Brackets Icons
  9. Ceratrior II theme
  10. Duplicate Files & Folders
  11. Extensions Rating
  12. File Tree Exclude
  13. HTML Block Selector
  14. Indent Guides
  15. Interactive Linter
  16. Markdown Preview
  17. Minifier
  18. Minimap
  19. Paste & Indent
  20. Select Lines
  21. Tabs - Custom Working
  22. Whitespace Normalizer

What should I look out for to determine why the extension is not working? Anything I should be aware of?

Thanks

-Steve

@iegik
Copy link

iegik commented Oct 28, 2015

conflicts with brackets-git

@MiguelCastillo
Copy link
Owner

@spietrek Sorry about that. Have you tried switching the order your linter definition to:

"interactive-linter.javascript": [
"jshint",
"jscs"
]

Interactive linter only supports one linter, even though the definition is an array. Array definition is just thinking ahead of features I would like to add and have not had to time to.

@iegik I am interested in what you said here. Is there a known conflict, something you have ran into, or just a guess?

@spietrek
Copy link
Author

Thanks Miguel. I am also running Brackets Git too.

-Steve Pietrek

On Oct 28, 2015, at 9:59 AM, Miguel Castillo [email protected] wrote:

@spietrek Sorry about that. Have you tried switching the order your linter definition to:

"interactive-linter.javascript": [
"jshint",
"jscs"
]
Interactive linter only supports one linter, even though the definition is an array. Array definition is just thinking ahead of features I would like to add and have not had to time to.

@iegik I am interested in what you said here. Is there a known conflict, something you have ran into, or just a guess?


Reply to this email directly or view it on GitHub.

@MiguelCastillo
Copy link
Owner

@spietrek Did you try switching the order of your linter definitions to have jshint first?

@iegik
Copy link

iegik commented Oct 30, 2015

@MiguelCastillo I have tried to switch the order of extensions. No effect.
Where actually can change extension load order?

@MiguelCastillo
Copy link
Owner

The actual bit that makes assumptions about there being an array and using the first entry is https://github.com/MiguelCastillo/Brackets-InteractiveLinter/blob/master/linterManager.js#L36

This issue certainly does not seem straight forward, so if you guys could help me diagnose it, that would be awesome.

What environments (OS) are you guys running?

The other thing that is interesting is

"linting.prefer": [
"JSHint",
"JSCS"
],

That's not needed unless you have install the corresponding extensions and not using interactive linter. Interactive linter will override the JS linting in Brackets.

@iegik
Copy link

iegik commented Nov 1, 2015

Ubuntu. I have installed both extensions - brackets-git and Brackets-InteractiveLinter. After Git extension is enabled - Brackets-InteractiveLinter do not work. Both extensions uses left side of editor content.

"linting.prefer": []

@MiguelCastillo
Copy link
Owner

Ohhh, that's interesting (in a bad way). Interactive linter works when brackets-git is not installed? :-/ I gotta look into that soon! Thanks for the info.

@spietrek
Copy link
Author

spietrek commented Nov 1, 2015

I have seen Interactive Linter not work on OSX. I also have Brackets Git installed. Seems to happen more often after installing or uninstalling other extensions and restarting Brackets. Sometimes takes multiple restarts with and without extensions to get things to work.

-Steve Pietrek

On Nov 1, 2015, at 4:06 PM, Miguel Castillo [email protected] wrote:

Ohhh, that's interesting (in a bad way). Interactive linter works when brackets-git is not installed? :-/ I gotta look into that soon! Thanks for the info.


Reply to this email directly or view it on GitHub.

@iegik
Copy link

iegik commented Nov 1, 2015

@MiguelCastillo, @spietrek I have removed all extensions except Git and Linter and switching them on/off, decided, that Linter does not work after Git is enabled.

@MiguelCastillo
Copy link
Owner

This is really helpful guys. I really don't run into these issues. I will try to repro with git. Thanks!!

@iegik
Copy link

iegik commented Nov 1, 2015

Note: Git hightlight row corner then line was changed, but Linter also mark that line, when it is with the error. I think marks are shown there, but they are not visible because Git replace/override them!

@jaymascarenas
Copy link

I have found that if you disable the extension and then enable it again the linter starts to work again. This is with brackets-git also installed. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants