Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ternific's suggestions don't close when moving caret laterally #79

Open
PhiLhoSoft opened this issue Dec 8, 2015 · 3 comments
Open

Comments

@PhiLhoSoft
Copy link

Using Brackets 1.5 on Windows 7, up-to-date plugins.

Say I have a line like: if (_.isUndefined(state))
When I type state, I get Tern suggestion list coming, refining as I type (more or less, I generally get a long list of unrelated words!).
If I select a suggestion, the list disappears, fine.
If I stubbornly finish to type the word (sometime it is faster than making a choice...), the list is still here. If I hit Home or End, it is closed, idem for Escape.
But if I move the caret with Left or Right arrow, the list follows the caret! The focus is still on the list, so I can't even use Up / Down arrow, unless I manually close the list.

If that's under control of your plugin, I would appreciate that when the caret goes out of the current identifier, the list closes itself. I prefer to invoke it explicitly when needed, rather than needing to close it explicitly...

@MiguelCastillo
Copy link
Owner

@PhiLhoSoft Moving to the left should close the window as soon as it encounters a dot. Is that not happening for you? Closing it when leaving the item you are currently hinting on makes sense. I can add some logic to trigger that... It is a little of behavior tweaking.

@MiguelCastillo
Copy link
Owner

@PhiLhoSoft I just merged to master changes to match more closely the behavior you describe. Could you please install the master branch and give some feedback?

Thanks!!

#80

@PhiLhoSoft
Copy link
Author

I lazily just copied the new content of the file in the file in Brackets' extension directory (and restarted it).

I indeed see an improvement. It can take some moves to close the window, but it is definitively an improvement.

I made a little "movie" to show what I mean:
ternific-issue 79-1

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants