Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] When insert Image (use slash menu) at the end of doc, clicking the "Upload file" button, it has no effect. #1690

Open
2 tasks done
yswang0927 opened this issue Feb 18, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@yswang0927
Copy link

Initial checklist

  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected packages and versions

v7.6.3

Link to runnable example

No response

Steps to reproduce

When use slash-menu insert Image at the end of doc (https://milkdown.dev/playground), clicking the "Upload file" button, it has no any effect.

But when focused "or paste link" input, and then clicking the "Upload file" button again, it's ok.

Meanwhile, insert Image elsewhere (not the end of doc), clicking the "Upload file" button, it's ok.

Expected behavior

Clicking the "Upload file" button should always ok.

Actual behavior

None

Runtime

Chrome

OS

Linux

Build and bundle tools

Vite

@yswang0927 yswang0927 added the bug Something isn't working label Feb 18, 2025
@Saul-Mirone
Copy link
Member

It's covered by the block selection. You can click somewhere else (like a paragraph) and click the button again. I'll fix it in next version.

@yswang0927
Copy link
Author

It's covered by the block selection. You can click somewhere else (like a paragraph) and click the button again. I'll fix it in next version.

Ok 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants