77 - Create nginx duplicator proxy chart #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
simisimis
reviewed
Jul 17, 2023
| ingress: | ||
| class: alb | ||
| annotations: {} | ||
| hosts: {} |
There was a problem hiding this comment.
I believe this should be hosts: [] instead of {}? Cause I see in your code you are ranging over hosts items.
Then looking at values I know that I need to define hosts:
hosts:
- host1
paths: []
- host2
paths: []
|
I wonder why you need to create a specific chart for this. You can just use the official nginx-ingress helm chart directly into your helmfile. There is a field customConfigMap: "" that you can use to apply your config. |
|
You are right, I will implement it with the official nginx helm chart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.