Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse_ledger.of_ledger_subset_exn shouldn't ever compute hashes #1573

Closed
emberian opened this issue Feb 5, 2019 · 1 comment
Closed

Sparse_ledger.of_ledger_subset_exn shouldn't ever compute hashes #1573

emberian opened this issue Feb 5, 2019 · 1 comment

Comments

@emberian
Copy link
Contributor

emberian commented Feb 5, 2019

Every hash it needs is already right there! here is the call to add_path that forms the core of of_ledger_subset_exn, and here is the definition of add_path. Note the calls to Hash.merge - these are expensive and wasteful. Instead, we could augment the notion of path to include the merge hashes.

I've started some work on the fix/no-sparse-ledger-hashing branch that does this. merkle_path_full needs to be implemented for all the relevant ledgers.

@emberian
Copy link
Contributor Author

emberian commented Feb 1, 2024

Done by #14594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants