You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Precomputed blocks are exported in json format, but the existing JSON serialization test doesn't cover all of the types included in the block.
Namely the following important data structures are completely absent from the test coverage:
Zkapp transactions
Completed works
This introduces a risk of accidentally changing JSON serialization format (without changing the bin_io serialization) that will be uncaught.
We need to enhance tests to be able to capture this case.
Preliminary Checks
Summary
Precomputed blocks are exported in
json
format, but the existing JSON serialization test doesn't cover all of the types included in the block.Namely the following important data structures are completely absent from the test coverage:
This introduces a risk of accidentally changing JSON serialization format (without changing the
bin_io
serialization) that will be uncaught.We need to enhance tests to be able to capture this case.
Steps to replicate this Issue
Merging this PR would cause troubles:
A Mina node running this PR would produce precomputed blocks of a format that is incompatible with the existing Mina node code
Console output
Platform
N/A
Build link(s)
No response
The text was updated successfully, but these errors were encountered: