Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance precomputed block tests with more datapoints #16501

Open
2 tasks done
georgeee opened this issue Jan 22, 2025 · 0 comments
Open
2 tasks done

Enhance precomputed block tests with more datapoints #16501

georgeee opened this issue Jan 22, 2025 · 0 comments

Comments

@georgeee
Copy link
Member

Preliminary Checks

Summary

Precomputed blocks are exported in json format, but the existing JSON serialization test doesn't cover all of the types included in the block.

Namely the following important data structures are completely absent from the test coverage:

  • Zkapp transactions
  • Completed works

This introduces a risk of accidentally changing JSON serialization format (without changing the bin_io serialization) that will be uncaught.
We need to enhance tests to be able to capture this case.

Steps to replicate this Issue

Merging this PR would cause troubles:

A Mina node running this PR would produce precomputed blocks of a format that is incompatible with the existing Mina node code

Console output

N/A

Platform

N/A

Build link(s)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant