Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SerializableItemStack): Allow setting item instrument tag. #84

Open
WaveOfWaves opened this issue Jan 21, 2025 · 2 comments
Open

Comments

@WaveOfWaves
Copy link

WaveOfWaves commented Jan 21, 2025

When using goat_horn as the base item, you currently can't change the default instrument sound. Adding playSound to an itemRightClick action plays item.goat_horn.sound.0 plus whatever sound is added through playSound. Using paper as the base item prevents the sound/instrument from being shown in the item tooltip. Adding an item instrument tag would solve both of these problems.

Suggested yaml syntax:

set.item:
  item:
    type: minecraft:goat_horn
    instrument: sing_goat_horn
@0ffz 0ffz transferred this issue from MineInAbyss/geary Jan 28, 2025
@0ffz
Copy link
Member

0ffz commented Jan 28, 2025

We also discussed potentially directly transforming the item syntax to json and creating vanilla items this way, however I think it's potentially worth maintaining feature by feature to keep the configs cleaner. Worth investigating.

@0ffz 0ffz changed the title Allow setting item instrument tag. feat(SerializableItemStack): Allow setting item instrument tag. Jan 28, 2025
@Boy0000
Copy link
Contributor

Boy0000 commented Jan 28, 2025

the datacomponent PR does most of the component stuff and 1.21.3 so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants