Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

All mods should use submodules #539

Open
Panquesito7 opened this issue Sep 24, 2019 · 3 comments
Open

All mods should use submodules #539

Panquesito7 opened this issue Sep 24, 2019 · 3 comments
Assignees
Labels
Priority: Low Attention not required Upstream

Comments

@Panquesito7
Copy link
Member

Panquesito7 commented Sep 24, 2019

Upstream mods here are very outdated (e.g. 3d Armor).

We should use submodules instead.
We must fork each mod that is here, update it to our needs, and add it as a submodule.

What do you think?

@BetterToAutomateTheWorld
Copy link
Member

Well, we use submodules for mods we didn't touch, for each one we modified for our server adaptation needs, we can't properly use submodules because we rewrite little parts to entire mods

For 3d_armor, we have custom armors values + new armors for class warrior/hunter/wizard + other mods synergy i surely forget (like regeneration rates, increase in run speed for hunter, etc. which are allocated to a full armor equiped)

It's why it's a really tricky to work with our mods, as many are linked together :/

@BetterToAutomateTheWorld
Copy link
Member

BetterToAutomateTheWorld commented Sep 26, 2019

If you're thinking about a way to handle this with submodules, go ahead, and enjoy yourself updating this mods :)

@Panquesito7
Copy link
Member Author

Panquesito7 commented Sep 26, 2019

Well, we use submodules for mods we didn't touch

Ahh, I see, so, I'll convert all non-modified mods (such as areas) into a submodule.
I'll set mods that already use submodules to point to the original repository (in case it's out-dated or not modified).

For 3d_armor, we have custom armors values + new armors for class warrior/hunter/wizard + other mods synergy i surely forget (like regeneration rates, increase in run speed for hunter, etc. which are allocated to a full armor equiped)

I've created a pull request (#540) to update 3d_armor to version 0.4.13.
It also updates many, many other mods.

(This is kinda off-topic to submodules, but I'll create a PR for the submodules soon.)

@Panquesito7 Panquesito7 added Priority: Low Attention not required and removed Priority: High Immediate attention needed labels Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Priority: Low Attention not required Upstream
Projects
None yet
Development

No branches or pull requests

2 participants