From 55ffc08867c59159bdfbd73f25abd1ecb84df7ed Mon Sep 17 00:00:00 2001 From: Timothy Carambat Date: Mon, 27 Jan 2025 10:50:20 -0800 Subject: [PATCH] [Chore] Add better data-handling for unknown providers (#3026) Add better data-handling for unknown providers --- .../GeneralSettings/PrivacyAndData/index.jsx | 32 ++++++----- .../Steps/DataHandling/index.jsx | 55 ++++++++++++++----- 2 files changed, 61 insertions(+), 26 deletions(-) diff --git a/frontend/src/pages/GeneralSettings/PrivacyAndData/index.jsx b/frontend/src/pages/GeneralSettings/PrivacyAndData/index.jsx index c107dbcd5e..7d3cec7920 100644 --- a/frontend/src/pages/GeneralSettings/PrivacyAndData/index.jsx +++ b/frontend/src/pages/GeneralSettings/PrivacyAndData/index.jsx @@ -8,6 +8,7 @@ import { EMBEDDING_ENGINE_PRIVACY, LLM_SELECTION_PRIVACY, VECTOR_DB_PRIVACY, + FALLBACKS, } from "@/pages/OnboardingFlow/Steps/DataHandling"; import { useTranslation } from "react-i18next"; @@ -67,6 +68,13 @@ function ThirdParty({ settings }) { const vectorDb = settings?.VectorDB || "lancedb"; const { t } = useTranslation(); + const LLMSelection = + LLM_SELECTION_PRIVACY?.[llmChoice] || FALLBACKS.LLM(llmChoice); + const EmbeddingEngine = + EMBEDDING_ENGINE_PRIVACY?.[embeddingEngine] || + FALLBACKS.EMBEDDING(embeddingEngine); + const VectorDb = VECTOR_DB_PRIVACY?.[vectorDb] || FALLBACKS.VECTOR(vectorDb); + return (
@@ -76,16 +84,16 @@ function ThirdParty({ settings }) {
LLM Logo

- {LLM_SELECTION_PRIVACY[llmChoice].name} + {LLMSelection.name}

@@ -96,20 +104,18 @@ function ThirdParty({ settings }) {
LLM Logo

- {EMBEDDING_ENGINE_PRIVACY[embeddingEngine].name} + {EmbeddingEngine.name}

@@ -119,16 +125,16 @@ function ThirdParty({ settings }) {
LLM Logo

- {VECTOR_DB_PRIVACY[vectorDb].name} + {VectorDb.name}

diff --git a/frontend/src/pages/OnboardingFlow/Steps/DataHandling/index.jsx b/frontend/src/pages/OnboardingFlow/Steps/DataHandling/index.jsx index 713891300d..1394ff19cd 100644 --- a/frontend/src/pages/OnboardingFlow/Steps/DataHandling/index.jsx +++ b/frontend/src/pages/OnboardingFlow/Steps/DataHandling/index.jsx @@ -388,6 +388,30 @@ export const EMBEDDING_ENGINE_PRIVACY = { }, }; +export const FALLBACKS = { + LLM: (provider) => ({ + name: "Unknown", + description: [ + `"${provider}" has no known data handling policy defined in AnythingLLM`, + ], + logo: AnythingLLMIcon, + }), + EMBEDDING: (provider) => ({ + name: "Unknown", + description: [ + `"${provider}" has no known data handling policy defined in AnythingLLM`, + ], + logo: AnythingLLMIcon, + }), + VECTOR: (provider) => ({ + name: "Unknown", + description: [ + `"${provider}" has no known data handling policy defined in AnythingLLM`, + ], + logo: AnythingLLMIcon, + }), +}; + export default function DataHandling({ setHeader, setForwardBtn, setBackBtn }) { const [llmChoice, setLLMChoice] = useState("openai"); const [loading, setLoading] = useState(true); @@ -425,6 +449,13 @@ export default function DataHandling({ setHeader, setForwardBtn, setBackBtn }) { ); + const LLMSelection = + LLM_SELECTION_PRIVACY?.[llmChoice] || FALLBACKS.LLM(llmChoice); + const EmbeddingEngine = + EMBEDDING_ENGINE_PRIVACY?.[embeddingEngine] || + FALLBACKS.EMBEDDING(embeddingEngine); + const VectorDb = VECTOR_DB_PRIVACY?.[vectorDb] || FALLBACKS.VECTOR(vectorDb); + return (
@@ -434,16 +465,16 @@ export default function DataHandling({ setHeader, setForwardBtn, setBackBtn }) {
LLM Logo

- {LLM_SELECTION_PRIVACY[llmChoice].name} + {LLMSelection.name}

@@ -454,20 +485,18 @@ export default function DataHandling({ setHeader, setForwardBtn, setBackBtn }) {
LLM Logo

- {EMBEDDING_ENGINE_PRIVACY[embeddingEngine].name} + {EmbeddingEngine.name}

@@ -477,16 +506,16 @@ export default function DataHandling({ setHeader, setForwardBtn, setBackBtn }) {
LLM Logo

- {VECTOR_DB_PRIVACY[vectorDb].name} + {VectorDb.name}