New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setpos to negative number error #62

Open

brianmichalk1 opened this issue Apr 18, 2023 · 0 comments

brianmichalk1 commented Apr 18, 2023 •

edited

Loading

If a setpos command is issued with a negative value, a resulting readpos value will be the abs() of the negative.

move -124.00 400
:>
 deg
:>
readpos
encoder -124.10
:>
setpos -10
:>
readpos
encoder 10.08

The current implementation:

static int setpos_cmd(sCmdUart *ptrUart,int argc, char * argv[])
{
	if (argc>=1)
	{
		int64_t a;
		float x;
		x=fabs(atof(argv[0]));
		a=ANGLE_FROM_DEGREES(x);
		stepperCtrl.setAngle(a);
		return 0;
	}
	return 1;
}

Is there a reason why the fabs() is used?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment