Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUGGESTION]: Same station should be excluded from the needs list for Travel mule. #163

Open
Chiether opened this issue Apr 15, 2023 · 0 comments
Labels
Suggestion A suggested change.

Comments

@Chiether
Copy link

Chiether commented Apr 15, 2023

  • Mule Type: M1 - Travel Mule.

Thanks for fixing the trading-loop at the same station for "Station Mule" (#162).
I would like to request a similar fix to be applied to "Travel Mule" as well.

Currently, the default value for "Profit override" (I'm not sure about this expression...) is set at 90.
While I understand the need to calculate profits after subtracting the sale price, I unintentionally caused a trading loop at the same station while using M1 at an NPC's trading station.

Changing the default-value to 100 would solve the problem, but I cannot suggest changing the default value as it may cause confusion. It should be resolved by manually setting the value to 100. However, I cannot think of a situation where a trading-loop at the same station would be necessary. Please consider this matter, though there is no need for an speedy fix.

Script log is here. (Sorry, I am Japanese player)

- アルゴン交易ステーション ... Argon trading station.
- 糧食 ... Food Ration.

[travelmule - MSA-456]
.....
need found: 1
Buying 1580 糧食 from ARG アルゴン交易ステーション at 21 to sell to ARG アルゴン交易ステーション at 20 for a profit of -1580
Nothing found, check back in a couple of minuites....

It might be acceptable to prioritize distribution at the risk of a deficit, but there's no need to conduct transactions at the same station, right?

@Chiether Chiether added the Suggestion A suggested change. label Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion A suggested change.
Projects
None yet
Development

No branches or pull requests

1 participant